Issue with flake8-noqa, flake8-eradicate and commented out code · Issue #255 · wemake-services/flake8-eradicate · GitHub
Skip to content

Issue with flake8-noqa, flake8-eradicate and commented out code #255

Open

Description

@shestakovks

Hello. I'm using flake8, flake8-noqa & flake8-eradicate. Until flake8-noqa==1.2.5 it worked fine, but now I encounter weird behaviour.

Python version

$ python --version
Python 3.9.10

Dependencies:
flake8==5.0.4
flake8-eradicate==1.4.0
flake8-noqa==1.2.9

Current behaviour

code.py

# a = 5
a = 7

flake8 run

$ flake8 code.py
code.py:1:1: E800 Found commented out code

code.py

# a = 5  # noqa: E800
a = 7

flake8 run

$ flake8 code.py
code.py:1:1: NQA102 "# noqa: E800" has no matching violations

Expected behaviour

code.py

# a = 5
a = 7

flake8 run

$ flake8 code.py
code.py:1:1: E800 Found commented out code

code.py

# a = 5  # noqa: E800
a = 7

flake8 run -- no error

$ flake8 code.py

I created the same issue in flake8-noqa repository but its author pointed out that the issue could be in your package.
Can you please take a look?

Activity

  1. njiles commented on Jun 10, 2024

    @njiles

    Hi - i just ran into this issue today, any updates? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions