fix(cli): cleanup writeTemp on dev server restart (#1693)

Mister-Hope · web-flow · commit ab6eada211a4 · 2026-04-01T12:14:17.000+08:00
diff --git a/packages/cli/src/commands/dev/dev.ts b/packages/cli/src/commands/dev/dev.ts
@@ -74,6 +74,10 @@ export const dev: DevCommand = async ({
       // close current dev server
       close(),
     ])
+
+    // clean up internal app state after all watchers and server are closed
+    app.writeTemp.cleanup()
+
     // restart dev command
     await dev({
       defaultAppConfig,
diff --git a/packages/core/src/app/resolveAppWriteTemp.ts b/packages/core/src/app/resolveAppWriteTemp.ts
@@ -15,7 +15,7 @@ interface WriteTempCache {
 export const resolveAppWriteTemp = (dir: AppDir): AppWriteTemp => {
   const cache = new Map<string, WriteTempCache>()
 
-  const writeTemp: AppWriteTemp = async (file: string, content: string) => {
+  const writeTemp = (async (file: string, content: string) => {
     const filePath = dir.temp(file)
     const contentHash = hash(content)
 
@@ -48,6 +48,10 @@ export const resolveAppWriteTemp = (dir: AppDir): AppWriteTemp => {
     }
     await item.current
     return filePath
+  }) as AppWriteTemp
+
+  writeTemp.cleanup = (): void => {
+    cache.clear()
   }
 
   return writeTemp
diff --git a/packages/core/src/types/app/utils.ts b/packages/core/src/types/app/utils.ts
@@ -61,4 +61,16 @@ export interface AppEnv {
 /**
  * Write temp file util
  */
-export type AppWriteTemp = (file: string, content: string) => Promise<string>
+export interface AppWriteTemp {
+  (file: string, content: string): Promise<string>
+
+  /**
+   * Clean up the internal write temp cache.
+   *
+   * This should be called when the dev server restarts
+   * to avoid stale cache and to release references to any
+   * in-memory write state so that pending write promises can
+   * complete and be garbage-collected naturally.
+   */
+  cleanup: () => void
+}
diff --git a/packages/core/tests/app/resolveAppWriteTemp.spec.ts b/packages/core/tests/app/resolveAppWriteTemp.spec.ts
@@ -74,6 +74,23 @@ describe('resolveAppWriteTemp', () => {
     expect(fs.outputFile).toHaveBeenCalledTimes(2)
   })
 
+  it('should re-write file after cleanup even if content is unchanged', async () => {
+    vi.mocked(fs.outputFile).mockClear()
+    const writeTemp = resolveAppWriteTemp(dir)
+    const file = 'cleanup.txt'
+    const content = 'foo'
+
+    await writeTemp(file, content)
+    expect(fs.outputFile).toHaveBeenCalledTimes(1)
+
+    // cleanup should clear the cache
+    writeTemp.cleanup()
+
+    // same content should be written again after cleanup
+    await writeTemp(file, content)
+    expect(fs.outputFile).toHaveBeenCalledTimes(2)
+  })
+
   it('should skip intermediate writes', async () => {
     vi.mocked(fs.outputFile).mockClear()
     const writeTemp = resolveAppWriteTemp(dir)
