perf: improve multilineCommentsRE regex (fix #10689) (#10751)

mrkldshv · web-flow · commit 51ed05915ae1 · 2022-11-03T07:35:25.000Z
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -912,7 +912,8 @@ export function toUpperCaseDriveLetter(pathName: string): string {
   return pathName.replace(/^\w:/, (letter) => letter.toUpperCase())
 }
 
-export const multilineCommentsRE = /\/\*(.|[\r\n])*?\*\//gm
+// Taken from https://stackoverflow.com/a/36328890
+export const multilineCommentsRE = /\/\*[^*]*\*+(?:[^/*][^*]*\*+)*\//gm
 export const singlelineCommentsRE = /\/\/.*/g
 export const requestQuerySplitRE = /\?(?!.*[\/|\}])/
 

Original file line number	Diff line number	Diff line change
`@@ -912,7 +912,8 @@ export function toUpperCaseDriveLetter(pathName: string): string {`
`912`	`912`	`return pathName.replace(/^\w:/, (letter) => letter.toUpperCase())`
`913`	`913`	`}`
`914`	`914`
`915`		`-export const multilineCommentsRE = /\/\(.\|[\r\n])?\*\//gm`
	`915`	`+// Taken from https://stackoverflow.com/a/36328890`
	`916`	`+export const multilineCommentsRE = /\/\[^]\+(?:[^/][^]\+)*\//gm`
`916`	`917`	`export const singlelineCommentsRE = /\/\/.*/g`
`917`	`918`	`export const requestQuerySplitRE = /\?(?!.*[\/\|\}])/`
`918`	`919`