fix: performance issue by gxcsoccer · Pull Request #625 · debug-js/debug · GitHub
Skip to content

fix: performance issue#625

Merged
Qix- merged 1 commit into
debug-js:hotfix-3.2.2from
gxcsoccer:fix-prof-issue
Oct 10, 2018
Merged

fix: performance issue#625
Qix- merged 1 commit into
debug-js:hotfix-3.2.2from
gxcsoccer:fix-prof-issue

Conversation

@gxcsoccer

Copy link
Copy Markdown

image

Comment thread src/common.js

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not run if debug is disabled

@fengmk2

fengmk2 commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

LGTM

@Qix-

Qix- commented Oct 9, 2018

Copy link
Copy Markdown
Member

Does this exist in master, too?

@Qix- Qix- added the awaiting-response This issue or pull request is awaiting a user's response label Oct 9, 2018
@gxcsoccer

Copy link
Copy Markdown
Author

Does this exist in master, too?

@Qix- master is ok

@Qix-

Qix- commented Oct 9, 2018

Copy link
Copy Markdown
Member

Don't worry about tests btw. I'll take a look at this a bit closer in a little while.

@Qix- Qix- added bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release and removed awaiting-response This issue or pull request is awaiting a user's response labels Oct 10, 2018
@Qix- Qix- merged commit f312a89 into debug-js:hotfix-3.2.2 Oct 10, 2018
@Qix-

Qix- commented Oct 10, 2018

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release

Development

Successfully merging this pull request may close these issues.

3 participants