
          CD into CWD before executing a runner in external terminals

5345cea

janko commented May 3, 2016

Member

I agree with this change, it's very useful to be able to cd to any directory in the Terminal, and just have test.vim bring you back to the project root.

Just as a note to others, I'm aware from #84 that some people might be relying on the shell being cd-ed to a different directory than Vim's working directory. However, after giving it some thought, I don't think test.vim should allow this, because file regexes might not work properly (e.g. file path is anotherapp/test/foo.js, but the regex checks for ^test/.*\.js). Also, if that subdirectory is a subproject with it's own structure (like it is in case of #84 a Rails engines), file detection methods like filereadable() will not work properly because they'll look in the wrong directory (whole project's root instead of subproject's root).

janko merged commit 7ef3c4d into vim-test:master

May 3, 2016

janko commented May 3, 2016

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!