Before PR:

After PR:

with default colorscheme and

• vim --clean
• hi Visual ctermbg=237 ctermfg=NONE:
• hi SpecialKey ctermfg=red
• set list listchars=tab:>-

before:

after:

hm, unfortunately it is not applied to the space, lead, multispace, eol parts of listchars

hm, unfortunately it is not applied to the space, lead, multispace, eol parts of listchars

Should be fixed for everything apart of eol, $ in the screenshot:

Current end of line is in quite a few other tests, failing if extra_attr is applied to eol. Tests could be fixed, but before doing it, @chrisbra, need your approve :)

e.g.:

command line..script /home/habamax/prj/habamax-vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_highlight_eol_with_cursorline_vertsplit[69]..Check_lcs_eol_attrs line 4: Expected [2114, 2114, 2114, 2114, 2057, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0] but got [2114, 2114, 2114, 2114, 2115, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0]
make: *** [Makefile:78: test_highlight] Error 1

PS, 2 failing tests seems unrelated to the changes I've made.

wrt endofline, this is how I would expect it to be:

@zeertzjq could suggest where to look to fix following:

or

As you can see if after the listchars there is a string, it inherits the highlight instead of using SpecialKey.

@zeertzjq I think existing dumps should work with the change(I have reverted all dump changes), but they are not, most probably due to unexpected blend of SpecialKey into Visual when it has both foreground and background set, e.g. evening colorscheme:

And it should look like this (because Visual has foreground):

Should I additionally check if Visual has foreground set before applying HLF_8?

I was expecting that following:

	    // Decide which of the highlight attributes to use.
	    attr_pri = TRUE;
#ifdef LINE_ATTR
	    if (area_attr != 0)
	    {
		wlv.char_attr = hl_combine_attr(wlv.line_attr, area_attr);

would properly combine Visual.