Documented workarounds

simasch · simasch · commit ac5e8a970671 · 2021-01-02T10:09:45.000+01:00
diff --git a/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.Api/RealTimeTestRunner.cs b/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.Api/RealTimeTestRunner.cs
@@ -104,6 +104,8 @@ public override void ConsumeResult(Action<@event> action)
             var cmd = new OracleCommand(proc, consumeConnection);
             cmd.Parameters.Add("id", OracleDbType.Varchar2, ParameterDirection.Input).Value = realtimeReporterId;
             cmd.Parameters.Add("lines_cursor", OracleDbType.RefCursor, ParameterDirection.Output);
+            
+            // https://stackoverflow.com/questions/2226769/bad-performance-with-oracledatareader
             cmd.InitialLOBFetchSize = -1;
 
             var reader = cmd.ExecuteReader();
diff --git a/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.Api/TestRunner.cs b/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.Api/TestRunner.cs
@@ -66,6 +66,8 @@ public string GetCoverageReport()
             var cmd = new OracleCommand(proc, consumeConnection);
             cmd.Parameters.Add("id", OracleDbType.Varchar2, ParameterDirection.Input).Value = coverageReporterId;
             cmd.Parameters.Add("lines_cursor", OracleDbType.RefCursor, ParameterDirection.Output);
+
+            // https://stackoverflow.com/questions/2226769/bad-performance-with-oracledatareader
             cmd.InitialLOBFetchSize = -1;
 
             var reader = cmd.ExecuteReader();
diff --git a/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.UI/TestRunnerWindow.cs b/PlsqlDeveloperUtPlsqlPlugin/utPLSQL.UI/TestRunnerWindow.cs
@@ -244,6 +244,10 @@ private static string JoinParts(string[] parts)
             return sb.ToString();
         }
 
+        /*
+         * Workaround for the progressbar animation that produces lagging
+         * https://stackoverflow.com/questions/5332616/disabling-net-progressbar-animation-when-changing-value
+         */
         private void UpdateProgressBar(int completedTests)
         {
             int newValue = completedTests * Steps + 1;

Original file line number	Diff line number	Diff line change
`@@ -244,6 +244,10 @@ private static string JoinParts(string[] parts)`
`244`	`244`	`return sb.ToString();`
`245`	`245`	`}`
`246`	`246`
	`247`	`+ /*`
	`248`	`+ * Workaround for the progressbar animation that produces lagging`
	`249`	`+ * https://stackoverflow.com/questions/5332616/disabling-net-progressbar-animation-when-changing-value`
	`250`	`+ */`
`247`	`251`	`private void UpdateProgressBar(int completedTests)`
`248`	`252`	`{`
`249`	`253`	`int newValue = completedTests * Steps + 1;`