Added version to AboutDialog. Fixed return value of Sysdba()

simasch · simasch · commit 841d54955cf8 · 2021-01-07T13:28:31.000+01:00
diff --git a/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/AboutDialog.Designer.cs b/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/AboutDialog.Designer.cs
diff --git a/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/AboutDialog.cs b/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/AboutDialog.cs
@@ -7,6 +7,10 @@ public partial class AboutDialog : Form
         public AboutDialog()
         {
             InitializeComponent();
+
+            var assembly = System.Reflection.Assembly.GetExecutingAssembly();
+            var fileVersionInfo = System.Diagnostics.FileVersionInfo.GetVersionInfo(assembly.Location);
+            lblVersion.Text = $"Version {fileVersionInfo.FileVersion}";
         }
 
         private void LinkLabel1_LinkClicked(object sender, LinkLabelLinkClickedEventArgs e)
diff --git a/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin.cs b/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin/PlsqlDeveloperUtPlsqlPlugin.cs
@@ -269,7 +269,7 @@ private static bool Sydba()
                 MessageBox.Show("You shouldn't run utPLSQL as SYSDBA.\n\nTest will not run.", "Connected as SYSDBA", MessageBoxButtons.OK, MessageBoxIcon.Error);
                 return true;
             }
-            return true;
+            return false;
         }
 
         private static void ConnectToDatabase()

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,10 @@ public partial class AboutDialog : Form`
`7`	`7`	`public AboutDialog()`
`8`	`8`	`{`
`9`	`9`	`InitializeComponent();`
	`10`	`+`
	`11`	`+ var assembly = System.Reflection.Assembly.GetExecutingAssembly();`
	`12`	`+ var fileVersionInfo = System.Diagnostics.FileVersionInfo.GetVersionInfo(assembly.Location);`
	`13`	`+ lblVersion.Text = $"Version {fileVersionInfo.FileVersion}";`
`10`	`14`	`}`
`11`	`15`
`12`	`16`	`private void LinkLabel1_LinkClicked(object sender, LinkLabelLinkClickedEventArgs e)`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ private static bool Sydba()`
`269`	`269`	`MessageBox.Show("You shouldn't run utPLSQL as SYSDBA.\n\nTest will not run.", "Connected as SYSDBA", MessageBoxButtons.OK, MessageBoxIcon.Error);`
`270`	`270`	`return true;`
`271`	`271`	`}`
`272`		`- return true;`
	`272`	`+ return false;`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`private static void ConnectToDatabase()`