# Note(fengqian): this message is the pattern of [E0611].

"No name 'urllib' in module '_MovedItems'",

# Note(xyang): these error messages are for the code [E1101].

# They should be ignored because 'sha256' and 'sha224' are functions in

# 'hashlib'.

"Module 'hashlib' has no 'sha256' member",

"Module 'hashlib' has no 'sha224' member",

# six.moves

"Instance of '_MovedItems' has no 'builtins' member",

# This error message is for code [E1101]

"Instance of 'ResourceFilterManager' has no '_list' member",

_cached_filename = None

_cached_content = None

def __init__(self, filename, lineno, line_content, code, message,

lintoutput):

self.filename = filename

self.lineno = lineno

self.line_content = line_content

self.code = code

self.message = message

self.lintoutput = lintoutput

@classmethod

def from_line(cls, line):

m = re.search(r"(\S+):(\d+): \[(\S+)(, \S+)?] (.*)", line)

if m is None:

return None

matched = m.groups()

filename, lineno, code, message = (matched[0], int(matched[1]),

matched[2], matched[-1])

if cls._cached_filename != filename:

with open(filename) as f:

cls._cached_content = list(f.readlines())

cls._cached_filename = filename

line_content = cls._cached_content[lineno - 1].rstrip()

return cls(filename, lineno, line_content, code, message,

line.rstrip())

@classmethod

def from_msg_to_dict(cls, msg):

"""Convert pylint output to a dict.

result = {}

for line in msg.splitlines():

obj = cls.from_line(line)

if obj is None or obj.is_ignored():

continue

key = obj.key()

if key not in result:

result[key] = []

result[key].append(obj)

return result

def is_ignored(self):

if self.code in ignore_codes:

return True

if any(self.filename.startswith(name) for name in ignore_modules):

return True

if any(msg in self.message for msg in ignore_messages):

return True

return False

def key(self):

if self.code in ["E1101", "E1103"]:

# These two types of errors are like Foo class has no member bar.

# We discard the source code so that the error will be ignored

# next time another Foo.bar is encountered.

return self.message, ""

return self.message, self.line_content.strip()

def json(self):

return json.dumps(self.__dict__)

def review_str(self):

return ("File %(filename)s\nLine %(lineno)d:%(line_content)s\n"

"%(code)s: %(message)s" %

{'filename': self.filename,

'lineno': self.lineno,

'line_content': self.line_content,

'code': self.code,

@classmethod

def print_json(cls, errors, output=sys.stdout):

print("# automatically generated by tools/lintstack.py", file=output)

for i in sorted(errors.keys()):

print(json.dumps(i), file=output)

@classmethod

def from_file(cls, filename):

keys = set()

for line in open(filename):

if line and line[0] != "#":

d = json.loads(line)

keys.add(tuple(d))

buff = StringIO()

reporter = text.TextReporter(output=buff)

args = [

"--msg-template='{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}'",

"-E", "cinderclient"]

lint.Run(args, reporter=reporter, exit=False)

val = buff.getvalue()

buff.close()

print("Generating", KNOWN_PYLINT_EXCEPTIONS_FILE)

if msg is None:

msg = run_pylint()

errors = LintOutput.from_msg_to_dict(msg)

with open(KNOWN_PYLINT_EXCEPTIONS_FILE, "w") as f:

print("Loading", KNOWN_PYLINT_EXCEPTIONS_FILE)

known = ErrorKeys.from_file(KNOWN_PYLINT_EXCEPTIONS_FILE)

if newmsg is None:

print("Running pylint. Be patient...")

newmsg = run_pylint()

errors = LintOutput.from_msg_to_dict(newmsg)

print("Unique errors reported by pylint: was %d, now %d."

% (len(known), len(errors)))

passed = True

for err_key, err_list in errors.items():

for err in err_list:

if err_key not in known:

print(err.lintoutput)

print()

passed = False

if passed:

print("Congrats! pylint check passed.")

redundant = known - set(errors.keys())

if redundant:

print("Extra credit: some known pylint exceptions disappeared.")

for i in sorted(redundant):

print(json.dumps(i))

print("Consider regenerating the exception file if you will.")

else:

print("Please fix the errors above. If you believe they are false "

"positives, run 'tools/lintstack.py generate' to overwrite.")

print("""Usage: tools/lintstack.py [generate|validate]

option = "validate"

if len(sys.argv) > 1:

option = sys.argv[1]

if option == "generate":

generate_error_keys()

elif option == "validate":

validate()

else: