Activity

1. jwaschkau

   changed the title [-]X-Up-Target not working for redirects[/-] [+]Server side X-Up-Target not working for redirects[/+] on Jul 7, 2021
2. triskweline commented on Jul 7, 2021

   

   triskweline

   on Jul 7, 2021

   Contributor

   More actions

   In your example:

   • Browser makes a request to /foo
   • Server responds with a redirect to /bar (response 1)
   • Browser sees the redirect and makes a second request to /bar
   • Server responds with HTML (response 2)

   Is the X-Up-Target header sent with response 1 or response 2?
3. triskweline

   added

   reproduction needed

   on Jul 7, 2021
4. jwaschkau commented on Jul 7, 2021

   

   jwaschkau

   on Jul 7, 2021

   Author

   More actions

   Hey Henning,

   the X-Up-Target header is sent with response 1.

   I also tried to send the header with response 2, which alters the target fragment on the client side as expected.
5. triskweline commented on Jul 8, 2021

   

   triskweline

   on Jul 8, 2021

   Last edited by triskweline

   Contributor

   More actions

   This needs to be implemented on the server. It is technically impossible for browser JavaScript to see the headers of a redirecting response ("response 1" above). Redirects are followed automatically, JavaScript only ever sees the final response.

   While fetch() has a { redirect: 'manual' } option that allows JS to not follow redirects, it does not allow access to the headers of a redirecting response.

   I saw that you're maintaining the django-unpoly integration. The unpoly-rails gem actually persists X-Up headers over redirects. If you would like to do something similar, here's how I did it:

   • For Unpoly requests, override Rails' redirect_to method to append all X-Up request/response headers as query parameters to the destination URL
   • When the user asks for e.g. an X-Up-Target header we look either in the query parameters or in the request headers.
   • Send an X-Up-Location header without these query parameters so they don't ever appear in the browser's location bar

   Relevant sections in the Ruby code and tests:

   • unpoly/lib/unpoly/rails/controller.rb

     Line 35 in e555c48

     def redirect_to(target, *args)

   • unpoly/spec_app/spec/gem/unpoly/rails/controller_spec.rb

     Line 960 in e555c48

     describe 'redirect_to' do

   Closing this issue since there's nothing we can do in Unpoly itself.
6. triskweline

   closed this as completedon Jul 8, 2021
7. jwaschkau commented on Jul 8, 2021

   

   jwaschkau

   on Jul 8, 2021

   Author

   More actions

   Hey Henning,

   thanks for your helpful answer. I will have a look at the redirect implementation of the Ruby-Integration and add it to the django-unpoly library.

   ❤️React with ❤️1Reacted by Henning Koch