feat!: remove acorn dependency and require custom parser setup

sxzz · sxzz · commit 40e4a049c390 · 2025-11-04T14:45:23.000+08:00
Users must now call `setParseImpl` to provide custom parsing logic before invoking `this.parse`. Acorn has been removed as a dependency. closes #480
diff --git a/package.json b/package.json
@@ -47,7 +47,6 @@
   },
   "dependencies": {
     "@jridgewell/remapping": "catalog:prod",
-    "acorn": "catalog:prod",
     "picomatch": "catalog:prod",
     "webpack-virtual-modules": "catalog:prod"
   },
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -51,7 +51,6 @@ catalogs:
 
   prod:
     '@jridgewell/remapping': ^2.3.5
-    acorn: ^8.15.0
     picomatch: ^4.0.3
     webpack-virtual-modules: ^0.6.2
 
diff --git a/src/bun/utils.ts b/src/bun/utils.ts
@@ -2,7 +2,7 @@ import type { Loader, PluginBuilder } from 'bun'
 import type { UnpluginBuildContext, UnpluginContext, UnpluginMessage } from '../types'
 import fs from 'node:fs'
 import path from 'node:path'
-import * as acorn from 'acorn'
+import { parse } from '../utils/parse'
 
 const ExtToLoader: Record<string, Loader> = {
   '.js': 'js',
@@ -47,14 +47,7 @@ export function createBuildContext(build: PluginBuilder): UnpluginBuildContext {
         fs.writeFileSync(outPath, emittedFile.source)
       }
     },
-    parse(code, opts = {}) {
-      return acorn.parse(code, {
-        sourceType: 'module',
-        ecmaVersion: 'latest',
-        locations: true,
-        ...opts,
-      })
-    },
+    parse,
     getNativeBuildContext() {
       return { framework: 'bun', build }
     },
diff --git a/src/esbuild/utils.ts b/src/esbuild/utils.ts
@@ -6,7 +6,7 @@ import { Buffer } from 'node:buffer'
 import fs from 'node:fs'
 import path from 'node:path'
 import remapping from '@jridgewell/remapping'
-import { parse } from '../utils/context'
+import { parse } from '../utils/parse'
 
 const ExtToLoader: Record<string, Loader> = {
   '.js': 'js',
diff --git a/src/farm/context.ts b/src/farm/context.ts
@@ -2,7 +2,7 @@ import type { CompilationContext } from '@farmfe/core'
 import type { UnpluginBuildContext, UnpluginContext } from '../types'
 import { Buffer } from 'node:buffer'
 import { extname } from 'node:path'
-import { parse } from '../utils/context'
+import { parse } from '../utils/parse'
 
 export function createFarmContext(
   context: CompilationContext,
diff --git a/src/index.ts b/src/index.ts
@@ -1,2 +1,3 @@
 export * from './define'
 export * from './types'
+export { setParseImpl } from './utils/parse'
diff --git a/src/rspack/context.ts b/src/rspack/context.ts
@@ -2,7 +2,7 @@ import type { Compilation, Compiler, LoaderContext } from '@rspack/core'
 import type { UnpluginBuildContext, UnpluginContext, UnpluginMessage } from '../types'
 import { Buffer } from 'node:buffer'
 import { resolve } from 'node:path'
-import { parse } from '../utils/context'
+import { parse } from '../utils/parse'
 
 export function createBuildContext(compiler: Compiler, compilation: Compilation, loaderContext?: LoaderContext): UnpluginBuildContext {
   return {
diff --git a/src/types.ts b/src/types.ts
@@ -1,10 +1,9 @@
 import type { CompilationContext as FarmCompilationContext, JsPlugin as FarmPlugin } from '@farmfe/core'
 import type { Compilation as RspackCompilation, Compiler as RspackCompiler, LoaderContext as RspackLoaderContext, RspackPluginInstance } from '@rspack/core'
-import type { Options as AcornOptions } from 'acorn'
 import type { BunPlugin, PluginBuilder as BunPluginBuilder } from 'bun'
 import type { BuildOptions, Plugin as EsbuildPlugin, Loader, PluginBuild } from 'esbuild'
 import type { Plugin as RolldownPlugin } from 'rolldown'
-import type { AstNode, EmittedAsset, PluginContextMeta as RollupContextMeta, Plugin as RollupPlugin, SourceMapInput } from 'rollup'
+import type { EmittedAsset, PluginContextMeta as RollupContextMeta, Plugin as RollupPlugin, SourceMapInput } from 'rollup'
 import type { Plugin as UnloaderPlugin } from 'unloader'
 import type { Plugin as VitePlugin } from 'vite'
 import type { Compilation as WebpackCompilation, Compiler as WebpackCompiler, LoaderContext as WebpackLoaderContext, WebpackPluginInstance } from 'webpack'
@@ -61,7 +60,7 @@ export interface UnpluginBuildContext {
   addWatchFile: (id: string) => void
   emitFile: (emittedFile: EmittedAsset) => void
   getWatchFiles: () => string[]
-  parse: (input: string, options?: Partial<AcornOptions>) => AstNode
+  parse: (input: string, options?: any) => any
   getNativeBuildContext?: (() => NativeBuildContext) | undefined
 }
 
diff --git a/src/utils/context.ts b/src/utils/context.ts
diff --git a/src/utils/parse.ts b/src/utils/parse.ts
@@ -0,0 +1,14 @@
+let parseImpl: ((code: string, opts?: any) => any) | undefined
+
+export function parse(code: string, opts: any = {}): any {
+  if (!parseImpl) {
+    throw new Error('Parse implementation is not set. Please call setParseImpl first.')
+  }
+  return parseImpl(code, opts)
+}
+
+export function setParseImpl(
+  customParse: (code: string, opts?: any) => any,
+): void {
+  parseImpl = customParse
+}
diff --git a/src/webpack/context.ts b/src/webpack/context.ts
@@ -4,7 +4,7 @@ import { Buffer } from 'node:buffer'
 import { createRequire } from 'node:module'
 import { resolve } from 'node:path'
 import process from 'node:process'
-import { parse } from '../utils/context'
+import { parse } from '../utils/parse'
 
 interface ContextOptions {
   addWatchFile: (file: string) => void
diff --git a/test/unit-tests/utils/context.test.ts b/test/unit-tests/utils/context.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest'
-import { parse } from '../../../src/utils/context'
+import { parse } from '../../../src/utils/parse'
 
 describe('parse', () => {
   it('should parse valid JavaScript code', () => {

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`export * from './define'`
`2`	`2`	`export * from './types'`
	`3`	`+export { setParseImpl } from './utils/parse'`