account for let &makeprg in Dispatch makeprg detection in compiler file · Issue #354 · tpope/vim-dispatch · GitHub
Skip to content

account for let &makeprg in Dispatch makeprg detection in compiler file #354

Open

Description

@Konfekt

The following idiom in a compiler/*.vim file

let &l:makeprg = 'm'
exe 'CompilerSet makeprg='..escape(&l:makeprg, ' "')

should work fine (maybe requiring further escapes!?), but is not accounted for by :Dispatch.
I suspect a regex searches for makeprg=\w+ ?

Activity

  1. Konfekt commented on Nov 7, 2024

    @Konfekt
    Author

    One can work around by " CompilerSet makeprg=m comments, but that seems rather something to be fixed on Dispatch's side

  2. tpope commented on Nov 7, 2024

    @tpope
    Owner

    The following idiom in a compiler/*.vim file

    Can you show me some real world examples?

    One can work around by " CompilerSet makeprg=m comments, but that seems rather something to be fixed on Dispatch's side

    Fixed how? Seems well beyond the limits of what can be accomplished with regex.

  3. Konfekt commented on Nov 7, 2024

    @Konfekt
    Author

    Can you show me some real world examples?

    https://github.com/vim/vim/pull/15804/files , https://github.com/vim/vim/pull/16007/files and https://github.com/vim/vim/pull/16001/files

    I sneaked in besaid comment just in case

    Fixed how? Seems well beyond the limits of what can be accomplished with regex.

    Maybe something like \v<makeprg>\W+=\W+<m> if not too slow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions