💚 Fix CI installs and tests by tiangolo · Pull Request #2 · fastapi/sqlmodel · GitHub
Skip to content

💚 Fix CI installs and tests#2

Merged
tiangolo merged 12 commits into
mainfrom
fix-poetry-ci
Aug 24, 2021
Merged

💚 Fix CI installs and tests#2
tiangolo merged 12 commits into
mainfrom
fix-poetry-ci

Conversation

@tiangolo

@tiangolo tiangolo commented Aug 24, 2021

Copy link
Copy Markdown
Member

💚 Fix CI installs and tests.

Poetry 1.2.0ax currently has an issue that was solved here: python-poetry/poetry-core#188, but is not released in the alpha branches.

This project uses Poetry 1.2.0ax to be able to use the Poetry Version Plugin https://github.com/tiangolo/poetry-version-plugin

Until there's a new release with that fix, this change installs poetry-core from Git, pinned to the version that fixes the problem.

This PR also fixes several dangling issues detected by the first CI runs, missing dev dependencies, type annotations, etc.

@tiangolo tiangolo changed the title 💚 Fix Poetry install in CI 💚 Fix CI installs and tests Aug 24, 2021
@codecov

codecov Bot commented Aug 24, 2021

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to commit August 24, 2021 18:13 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

@tiangolo tiangolo merged commit 7f8a1a5 into main Aug 24, 2021
@tiangolo tiangolo deleted the fix-poetry-ci branch August 24, 2021 18:14
tiangolo pushed a commit that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant