{{ message }}
🐛Fix docs light/dark theme switcher#1
Merged
Merged
Conversation
Contributor
Author
|
Looks similar if not the same? fastapi/fastapi#3246 |
Contributor
Author
|
Maybe swapping the icons would be better too, sure. While using the light theme the bulb would be "turned on" and with the dark theme it would be "off". Makes sense to me. However fastapi/fastapi#3246 does not fix the tooltip texts. |
Contributor
Author
|
Anyway, swapping the text alone seems like an improvement for me. Swapping the icons can be something for another PR. |
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 97.27%
=======================================
Files ? 175
Lines ? 5842
Branches ? 0
=======================================
Hits ? 5683
Misses ? 159
Partials ? 0 Continue to review full report at Codecov.
|
Member
tiangolo
changed the title
ghost
reviewed
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple fix for the lightbulb's tooltip on the documentation site:
Before:
After:
