{{ message }}
Repository navigation
html grammar should allow space characters (including line feed) before the > in end tags #97
Description
From @joshunger on December 9, 2018 22:13
Issue Type: Bug
Syntax highlighting is white and incorrect for html
Minimal example:
<!DOCTYPE html>
<html lang="en">
<head>
<title>foo</title>
</head>
<body>
<div></div>
<script src="http://dummy"></script
><script src="http://dummy"></script
><!--[if lte IE 9]><script src="http://dummy"></script><![endif]-->
</body>
</html>
An extension formatted it but it appears the syntax highlighting is a code bug?
VS Code version: Code - Insiders 1.30.0-insider (85f805acf9436381b878cab5ab6c5146beec7893, 2018-12-05T12:13:44.894Z)
OS version: Darwin x64 18.2.0
System Info
Extensions (18)
Copied from original issue: microsoft/vscode#64699
Activity
alexr00 commentedon Dec 10, 2018
The html grammar we use doesn't handle the greater than symbol being on the next line like this:
Is this something that you expect to be ok? It isn't a standard way of formatting html as far as I know.
alexr00 commentedon Dec 10, 2018
From @joshunger on December 10, 2018 12:27
I was wondering that too.
It seems to validate at https://validator.w3.org/.
Is this the correct spec? See https://www.w3.org/TR/html5/syntax.html#end-tags
And https://www.w3.org/TR/html5/infrastructure.html#space-characters says -
🤔
What does Code use for html syntax?
alexr00 commentedon Dec 10, 2018
The html formatter is here, but I don't know all the details. The html grammar we use for syntax highlighting is here: https://github.com/textmate/html.tmbundle.
You mentioned that you're using an extension to provide formatting: the build in VS Code html formatting fixed those strange end tags for me. Based on the spec you linked they're allowed, they just aren't what I expected to see.
Since the issue is with the grammar, I can forward this issue to https://github.com/textmate/html.tmbundle.
[-]syntax highlighting is white and incorrect for html[/-][+]html grammar should allow space characters (including line feed) before the > in end tags[/+]