Fixed: Ensure custom log level doesn't log if its off or null

agnostic-apollo · agnostic-apollo · commit 197979fdcc69 · 2021-09-04T05:28:39.000+05:00
diff --git a/termux-shared/src/main/java/com/termux/shared/logger/Logger.java b/termux-shared/src/main/java/com/termux/shared/logger/Logger.java
@@ -439,6 +439,7 @@ public static boolean isLogLevelValid(Integer logLevel) {
     /** Check if custom log level is valid and >= {@link #CURRENT_LOG_LEVEL}. If custom log level is
      * not valid then {@link #LOG_LEVEL_VERBOSE} must be >= {@link #CURRENT_LOG_LEVEL}. */
     public static boolean shouldEnableLoggingForCustomLogLevel(Integer customLogLevel) {
+        if (customLogLevel == null || CURRENT_LOG_LEVEL == LOG_LEVEL_OFF) return false;
         customLogLevel = Logger.isLogLevelValid(customLogLevel) ? customLogLevel: Logger.LOG_LEVEL_VERBOSE;
         return (customLogLevel >= CURRENT_LOG_LEVEL);
     }

Original file line number	Diff line number	Diff line change
`@@ -439,6 +439,7 @@ public static boolean isLogLevelValid(Integer logLevel) {`
`439`	`439`	`/** Check if custom log level is valid and >= {@link #CURRENT_LOG_LEVEL}. If custom log level is`
`440`	`440`	`* not valid then {@link #LOG_LEVEL_VERBOSE} must be >= {@link #CURRENT_LOG_LEVEL}. */`
`441`	`441`	`public static boolean shouldEnableLoggingForCustomLogLevel(Integer customLogLevel) {`
	`442`	`+ if (customLogLevel == null \|\| CURRENT_LOG_LEVEL == LOG_LEVEL_OFF) return false;`
`442`	`443`	`customLogLevel = Logger.isLogLevelValid(customLogLevel) ? customLogLevel: Logger.LOG_LEVEL_VERBOSE;`
`443`	`444`	`return (customLogLevel >= CURRENT_LOG_LEVEL);`
`444`	`445`	`}`