Update SDK (#40) · temporalio/samples-python@af94df0 · GitHub
Skip to content

Commit af94df0

Browse files
authored
Update SDK (#40)
1 parent 614fe66 commit af94df0

4 files changed

Lines changed: 13 additions & 89 deletions

File tree

‎README.md‎

Lines changed: 0 additions & 4 deletions

‎open_telemetry/worker.py‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,9 @@
1010
from opentelemetry.sdk.trace import TracerProvider
1111
from opentelemetry.sdk.trace.export import BatchSpanProcessor
1212
from temporalio import activity, workflow
13-
from temporalio.bridge.runtime import (
14-
MetricsConfig,
15-
OpenTelemetryConfig,
16-
Runtime,
17-
TelemetryConfig,
18-
)
1913
from temporalio.client import Client
2014
from temporalio.contrib.opentelemetry import TracingInterceptor
15+
from temporalio.runtime import OpenTelemetryConfig, Runtime, TelemetryConfig
2116
from temporalio.worker import Worker
2217

2318

@@ -49,13 +44,7 @@ def init_runtime_with_telemetry() -> Runtime:
4944
# Setup SDK metrics to OTel endpoint
5045
return Runtime(
5146
telemetry=TelemetryConfig(
52-
# TODO(cretz): Remove type ignore when
53-
# https://github.com/temporalio/sdk-python/issues/198 fixed
54-
metrics=MetricsConfig( # type: ignore
55-
opentelemetry=OpenTelemetryConfig(
56-
url="http://localhost:4317", headers={}
57-
)
58-
)
47+
metrics=OpenTelemetryConfig(url="http://localhost:4317")
5948
)
6049
)
6150

‎poetry.lock‎

Lines changed: 10 additions & 71 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pyproject.toml‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)