deps: V8: backport 9fb4444bfc46 · targos/node@4ee0bfd · GitHub
Skip to content

Commit 4ee0bfd

Browse files
srl295joyeecheung
authored andcommitted
deps: V8: backport 9fb4444bfc46
Original commit message: Fix Temporal compilation with system or no ICU build: Fix Temporal compilation with system or no ICU Add new build flag, v8_enable_temporal_systemicu, off by default When on, it will remove references to the internal ICU udatamem.h header file Obviates CLs 7769990 / 7831715 See: https://unicode-org.atlassian.net/browse/ICU-23400 See: Node: nodejs#62676 See: V8: https://chromium-review.googlesource.com/c/v8/v8/+/7831715 See: Homebrew: Homebrew/homebrew-core#281707 Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Also includes: fix: fix for no-icu build thanks @aduh95 nodejs#62676 (comment) NO_IFTTT=No Temporal via Bazel Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8281487 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#110039} Refs: v8/v8@9fb4444 PR-URL: nodejs#65992 Fixes: nodejs#62676 Refs: srl295/v8@cd89fe6 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 43590e6 commit 4ee0bfd

5 files changed

Lines changed: 54 additions & 5 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion

‎deps/v8/AUTHORS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ Stefan Penner <stefan.penner@gmail.com>
303303
Stefan Stojanovic <stefko.stojanovic@gmail.com>
304304
Stephan Hartmann <stha09@googlemail.com>
305305
Stephen Belanger <stephen.belanger@datadoghq.com>
306+
Steven R. Loomis <srl295@gmail.com>
306307
Sylvestre Ledru <sledru@mozilla.com>
307308
Takeshi Yoneda <takeshi@tetrate.io>
308309
Taketoshi Aono <brn@b6n.ch>

‎deps/v8/BUILD.gn‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1391,6 +1391,9 @@ config("features") {
13911391
if (v8_enable_temporal_support) {
13921392
defines += [ "V8_TEMPORAL_SUPPORT" ]
13931393
}
1394+
if (v8_enable_temporal_systemicu) {
1395+
defines += [ "V8_ENABLE_TEMPORAL_SYSTEMICU" ]
1396+
}
13941397
if (v8_enable_local_handle_zapping) {
13951398
defines += [ "ENABLE_LOCAL_HANDLE_ZAPPING" ]
13961399
}
@@ -3233,6 +3236,7 @@ generated_file("v8_generate_features_json") {
32333236
v8_enable_hugepage = v8_enable_hugepage
32343237
v8_enable_i18n_support = v8_enable_i18n_support
32353238
v8_enable_temporal_support = v8_enable_temporal_support
3239+
v8_enable_temporal_systemicu = v8_enable_temporal_systemicu
32363240
v8_enable_javascript_promise_hooks = v8_enable_javascript_promise_hooks
32373241
v8_enable_lite_mode = v8_enable_lite_mode
32383242
v8_enable_map_packing = v8_enable_map_packing

‎deps/v8/gni/v8.gni‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ declare_args() {
6262
# Furthermore, some architectures don't have Rust toolchains in Chromium
6363
v8_enable_temporal_support = !(defined(build_with_node) && build_with_node)
6464

65+
# by default, don't enable compiling Temporal with a system ICU4C
66+
# (assume private headers are available)
67+
v8_enable_temporal_systemicu = false
68+
6569
# Use static libraries instead of source_sets.
6670
v8_static_library = false
6771

‎deps/v8/src/objects/js-temporal-zoneinfo64.cc‎

Lines changed: 44 additions & 4 deletions

0 commit comments

Comments
 (0)