{{ message }}
Repository navigation
Commit 4ee0bfd
deps: V8: backport 9fb4444bfc46
Original commit message:
Fix Temporal compilation with system or no ICU
build: Fix Temporal compilation with system or no ICU
Add new build flag, v8_enable_temporal_systemicu, off by default When
on, it will remove references to the internal ICU udatamem.h header file
Obviates CLs 7769990 / 7831715
See: https://unicode-org.atlassian.net/browse/ICU-23400 See: Node:
nodejs#62676 See: V8:
https://chromium-review.googlesource.com/c/v8/v8/+/7831715 See:
Homebrew: Homebrew/homebrew-core#281707
Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6
Also includes:
fix: fix for no-icu build
thanks @aduh95
nodejs#62676 (comment)
NO_IFTTT=No Temporal via Bazel
Change-Id: Ibc460c68189d32e154c53eddfcda56bc7bca4fc6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8281487
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Reviewed-by: Olivier Flückiger <olivf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110039}
Refs: v8/v8@9fb4444
PR-URL: nodejs#65992
Fixes: nodejs#62676
Refs: srl295/v8@cd89fe6
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>1 parent 43590e6 commit 4ee0bfd
5 files changed
Lines changed: 54 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| 306 | + | |
306 | 307 | | |
307 | 308 | | |
308 | 309 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1391 | 1391 | | |
1392 | 1392 | | |
1393 | 1393 | | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
1394 | 1397 | | |
1395 | 1398 | | |
1396 | 1399 | | |
| |||
3233 | 3236 | | |
3234 | 3237 | | |
3235 | 3238 | | |
| 3239 | + | |
3236 | 3240 | | |
3237 | 3241 | | |
3238 | 3242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| |||

0 commit comments