Comparing TheOdinProject:main...taladan:main · TheOdinProject/javascript-exercises · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TheOdinProject/javascript-exercises
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: taladan/javascript-exercises
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 20 files changed
  • 1 contributor

Commits on Feb 15, 2023

  1. Add missing text to return

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    2dcd108 View commit details
    Browse the repository at this point in the history
  2. Complete first test

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    15f24c7 View commit details
    Browse the repository at this point in the history
  3. Pass all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9cd6126 View commit details
    Browse the repository at this point in the history
  4. Passed all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d4cf4d2 View commit details
    Browse the repository at this point in the history
  5. Solve for all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    88be8a5 View commit details
    Browse the repository at this point in the history
  6. Complete and pass all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    318dc49 View commit details
    Browse the repository at this point in the history
  7. Solve for all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a8dad85 View commit details
    Browse the repository at this point in the history
  8. Solve for all tests

    taladan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    7fa37c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Refactor using filter

    Filter is powerful stuff.  Researched using arrow functions and splice
    at first, then realized I was trying to basically filter one function
    against another...changed the direction of my thoughts entirely and
    found this:
    https://stackoverflow.com/questions/34901593/how-to-filter-an-array-from-all-elements-of-another-array
    taladan committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d556124 View commit details
    Browse the repository at this point in the history
  2. Complete all tests for calculator.js

    So, reduce is definitely the way to go when doing mathematical
    operations on an array where you're looking for a single result.
    taladan committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    62e9605 View commit details
    Browse the repository at this point in the history
  3. Pass tests

    taladan committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    7a3b9e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Code a fib seq generator position finder

    This one was more intricate and I ended up
    going to SO to find a solution to it.  I got the
    original code down by looking up a fibonacci seq
    definition and it worked fine.  The refactor
    with `fill()` and `reduce()` ended up taking some
    time to understand and parse through.  I'll likely
    end up having to look this solution up again if
    I end up having to generate a sequence and pull a position
    from it.  I did end up having to tweak the code from
    the solution I found on SO to fit my particular needs.
    taladan committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    8557566 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0df4130 View commit details
    Browse the repository at this point in the history
Loading