stackit-website/.github/pull_request_template.md at main · stackitgroup/stackit-website · GitHub
Skip to content

Latest commit

 

History

History
28 lines (25 loc) · 1.73 KB

File metadata and controls

28 lines (25 loc) · 1.73 KB

🚀 ClickUp Task

Link: TASK-URL

✅ Self-Review Checklist

⚙️ General (Frontend and Backend)

  • Ticket Requirements: The functionality meets all acceptance criteria from the ClickUp task.
  • Business Logic: Main use cases and edge cases have been covered.
  • Unit/Integration Tests: Necessary tests have been created or updated. All tests pass.
  • Code Quality: Code is clean, follows style guidelines, and has no unnecessary commented code.
  • Environment Variables: New environment variables are in .env.example and documented.
  • Documentation: Relevant documentation has been updated (README, Swagger, Storybook, etc.).
  • Clean Commits: Commit history is clear and descriptive.

🗄️ Backend (NestJS)

  • API Endpoints: Correct HTTP methods and status codes are used. JSON response is consistent.
  • Validation and Security: Input data (DTOs) is validated and endpoints are protected.
  • Database: Queries are efficient and migrations have been created correctly.
  • Error Handling: API returns clear and useful error messages.
  • Performance: No obvious bottlenecks present.

🖥️ Frontend (React)

  • UI and Design: Interface is faithful to the design and fully responsive.
  • Components: Reusable components have been created and state management is efficient.
  • User Experience (UX): Loading and error states are handled clearly for the user.
  • Accessibility (a11y): Correct use of semantic HTML and UI is keyboard navigable.
  • Compatibility: Tested in the web browsers supported by the project.
  • Performance: Images are optimized and lazy loading is applied where necessary.