Activity

1. mp911de commented on Dec 10, 2024

   

   mp911de

   on Dec 10, 2024

   Member

   More actions

   You can register a ClientHttpRequestFactory wrapped in org.springframework.vault.config.AbstractVaultConfiguration.ClientFactoryWrapper:

   SpringApplication application = new SpringApplication(…);
   application.addBootstrapRegistryInitializer(
   		registry -> {
   
   			registry.registerIfAbsent(AbstractVaultConfiguration.ClientFactoryWrapper.class, ctx -> {
   
   				HttpComponentsClientHttpRequestFactory factory = …;
   				return new AbstractVaultConfiguration.ClientFactoryWrapper(factory);
   
   			});
   		});

   Let me know whether this helps.

   👍React with 👍1Reacted by Wai Loon
2. Mingkongchan0 commented on Dec 11, 2024

   

   Mingkongchan0

   on Dec 11, 2024

   Last edited by Mingkongchan0

   Author

   More actions

   Hi @mp911de, I don't think it works.

   

   From what I see, the VaultConfigDataLoader class registers the clientHttpRequestFactory bean if its absent, and at this point in the bootstrap, there isn't a clientHttpRequestFactory instance yet.

   Code below for reference. Please do advise if I'm misconfiguring this.

   @SpringBootApplication
   @Slf4j
   public class VaultTestApplication {
       public static void main(String[] args) {
           SpringApplication application = new SpringApplication();
           application.addBootstrapRegistryInitializer(
                   registry -> {
                       registry.registerIfAbsent(AbstractVaultConfiguration.ClientFactoryWrapper.class, ctx -> {
                           HttpComponentsClientHttpRequestFactory factory = ClientHttpRequestFactoryBuilder.httpComponents()
                                   .withDefaultRequestConfigCustomizer(builder -> builder.setProtocolUpgradeEnabled(false)).build();
                           return new AbstractVaultConfiguration.ClientFactoryWrapper(factory);
                       });
                   });
           SpringApplication.run(VaultTestApplication.class);
       }
   }
   
3. mp911de commented on Dec 11, 2024

   

   mp911de

   on Dec 11, 2024

   Member

   More actions

   Have you noticed that you're not using the customized application object, but instead, you're running SpringApplication.run(VaultTestApplication.class);? It should be application.run(args).
4. mp911de

   added

   status: waiting-for-feedback

   on Dec 11, 2024
5. v-ladynev commented on Dec 12, 2024

   

   v-ladynev

   on Dec 12, 2024

   Last edited by v-ladynev

   More actions

   @mp911de An example with application.addBootstrapRegistryInitializer() doesn't work even corrected.
   addBootstrapRegistryInitializer() just adds InstanceSupplier not a bean.
   And that InstanceSupplier never called because AbstractVaultConfiguration.ClientFactoryWrapper is already created during bootstrap.

   I am using bootstrap.yaml for Vault configuration.
6. mp911de commented on Dec 13, 2024

   

   mp911de

   on Dec 13, 2024

   Member

   More actions

   I am using bootstrap.yaml for Vault configuration.

   This is an important detail because in that case, you need to define an override bean (@Bean ClientFactoryWrapper). To do so, create a boostrap autoconfiguration and register it with spring.factories under the org.springframework.cloud.bootstrap.BootstrapConfiguration key.
7. v-ladynev commented on Dec 13, 2024

   

   v-ladynev

   on Dec 13, 2024

   More actions

   @mp911de It works. Thank you very much.

   Also this configuration parameter should be added to bootstrap.yaml

   spring.main.allow-bean-definition-overriding: true
8. reachjyo commented on Dec 17, 2024

   

   reachjyo

   on Dec 17, 2024

   Last edited by reachjyo

   More actions

   @mp911de Even after adding the following fix , I still dont see the issue fixed , should I turn on the property spring.main.allow-bean-definition-overriding: true as well ?

   We are not using Spring's Vault then should we still follow the suggestion you mentioned earlier , ie

   This is an important detail because in that case, you need to define an override bean (@bean ClientFactoryWrapper). To do so, create a boostrap autoconfiguration and register it with spring.factories under the org.springframework.cloud.bootstrap.BootstrapConfiguration key.

       @Bean
       public HttpComponentsClientHttpRequestFactoryBuilder httpComponentsClientHttpRequestFactoryBuilder() {
           return ClientHttpRequestFactoryBuilder.httpComponents()
                   .withDefaultRequestConfigCustomizer((builder) -> builder.setProtocolUpgradeEnabled(false));
       }