Lint

Andy Hanson · Andy Hanson · commit 2dd23fa0a813 · 2017-03-27T11:51:13.000-07:00
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -561,7 +561,7 @@ namespace FourSlash {
                 const errors = this.getDiagnostics(fileName);
                 if (errors.length) {
                     this.printErrorLog(/*expectErrors*/ false, errors);
-                    const error = errors[0]
+                    const error = errors[0];
                     this.raiseError(`Found an error: ${error.file.fileName}@${error.start}: ${error.messageText}`);
                 }
             });
@@ -1174,7 +1174,7 @@ namespace FourSlash {
             let findInStrings: boolean, findInComments: boolean, ranges: Range[];
             if (ts.isArray(options)) {
                 findInStrings = findInComments = false;
-                ranges = options
+                ranges = options;
             }
             else {
                 findInStrings = !!options.findInStrings;
diff --git a/src/services/importTracker.ts b/src/services/importTracker.ts
@@ -17,7 +17,7 @@ namespace ts.FindAllReferences {
         return (exportSymbol, exportInfo, isForRename) => {
             const { directImports, indirectUsers } = getImportersForExport(sourceFiles, allDirectImports, exportInfo, checker);
             return { indirectUsers, ...getSearchesFromDirectImports(directImports, exportSymbol, exportInfo.exportKind, checker, isForRename) };
-        }
+        };
     }
 
     /** Info about an exported symbol to perform recursive search on. */
@@ -86,7 +86,7 @@ namespace ts.FindAllReferences {
                     case SyntaxKind.ImportDeclaration:
                         const namedBindings = direct.importClause && direct.importClause.namedBindings;
                         if (namedBindings && namedBindings.kind === SyntaxKind.NamespaceImport) {
-                            handleNamespaceImport(direct, namedBindings.name)
+                            handleNamespaceImport(direct, namedBindings.name);
                         }
                         else {
                             directImports.push(direct);
@@ -418,7 +418,7 @@ namespace ts.FindAllReferences {
                     // Get the symbol for the `export =` node; its parent is the module it's the export of.
                     const exportingModuleSymbol = parent.symbol.parent;
                     Debug.assert(!!exportingModuleSymbol);
-                    return { kind: ImportExport.Export, symbol, exportInfo: { exportingModuleSymbol, exportKind: ExportKind.ExportEquals } }
+                    return { kind: ImportExport.Export, symbol, exportInfo: { exportingModuleSymbol, exportKind: ExportKind.ExportEquals } };
                 }
             }
         }
@@ -445,7 +445,7 @@ namespace ts.FindAllReferences {
 
         function exportInfo(symbol: Symbol, kind: ExportKind): ExportedSymbol {
             const exportInfo = getExportInfo(symbol, kind, checker);
-            return exportInfo && { kind: ImportExport.Export, symbol, exportInfo }
+            return exportInfo && { kind: ImportExport.Export, symbol, exportInfo };
         }
 
         // Not meant for use with export specifiers or export assignment.
@@ -524,6 +524,6 @@ namespace ts.FindAllReferences {
     }
 
     function isExternalModuleImportEquals({ moduleReference }: ImportEqualsDeclaration): boolean {
-        return moduleReference.kind === SyntaxKind.ExternalModuleReference && moduleReference.expression.kind === SyntaxKind.StringLiteral
+        return moduleReference.kind === SyntaxKind.ExternalModuleReference && moduleReference.expression.kind === SyntaxKind.StringLiteral;
     }
 }
diff --git a/src/services/types.ts b/src/services/types.ts
@@ -481,13 +481,9 @@ namespace ts {
         displayParts: SymbolDisplayPart[];
     }
 
-    //!!! internal implementation details leaked!!!
-    export interface ReferencedSymbolOf<T extends DocumentSpan> {
+    export interface ReferencedSymbol {
         definition: ReferencedSymbolDefinitionInfo;
-        references: T[];
-    }
-
-    export interface ReferencedSymbol extends ReferencedSymbolOf<ReferenceEntry> {
+        references: ReferenceEntry[];
     }
 
     export enum SymbolDisplayPartKind {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ namespace ts.FindAllReferences {`
`17`	`17`	`return (exportSymbol, exportInfo, isForRename) => {`
`18`	`18`	`const { directImports, indirectUsers } = getImportersForExport(sourceFiles, allDirectImports, exportInfo, checker);`
`19`	`19`	`return { indirectUsers, ...getSearchesFromDirectImports(directImports, exportSymbol, exportInfo.exportKind, checker, isForRename) };`
`20`		`- }`
	`20`	`+ };`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`/** Info about an exported symbol to perform recursive search on. */`
`@@ -86,7 +86,7 @@ namespace ts.FindAllReferences {`
`86`	`86`	`case SyntaxKind.ImportDeclaration:`
`87`	`87`	`const namedBindings = direct.importClause && direct.importClause.namedBindings;`
`88`	`88`	`if (namedBindings && namedBindings.kind === SyntaxKind.NamespaceImport) {`
`89`		`- handleNamespaceImport(direct, namedBindings.name)`
	`89`	`+ handleNamespaceImport(direct, namedBindings.name);`
`90`	`90`	`}`
`91`	`91`	`else {`
`92`	`92`	`directImports.push(direct);`
`@@ -418,7 +418,7 @@ namespace ts.FindAllReferences {`
`418`	`418`	// Get the symbol for the `export =` node; its parent is the module it's the export of.
`419`	`419`	`const exportingModuleSymbol = parent.symbol.parent;`
`420`	`420`	`Debug.assert(!!exportingModuleSymbol);`
`421`		`- return { kind: ImportExport.Export, symbol, exportInfo: { exportingModuleSymbol, exportKind: ExportKind.ExportEquals } }`
	`421`	`+ return { kind: ImportExport.Export, symbol, exportInfo: { exportingModuleSymbol, exportKind: ExportKind.ExportEquals } };`
`422`	`422`	`}`
`423`	`423`	`}`
`424`	`424`	`}`
`@@ -445,7 +445,7 @@ namespace ts.FindAllReferences {`
`445`	`445`
`446`	`446`	`function exportInfo(symbol: Symbol, kind: ExportKind): ExportedSymbol {`
`447`	`447`	`const exportInfo = getExportInfo(symbol, kind, checker);`
`448`		`- return exportInfo && { kind: ImportExport.Export, symbol, exportInfo }`
	`448`	`+ return exportInfo && { kind: ImportExport.Export, symbol, exportInfo };`
`449`	`449`	`}`
`450`	`450`
`451`	`451`	`// Not meant for use with export specifiers or export assignment.`
`@@ -524,6 +524,6 @@ namespace ts.FindAllReferences {`
`524`	`524`	`}`
`525`	`525`
`526`	`526`	`function isExternalModuleImportEquals({ moduleReference }: ImportEqualsDeclaration): boolean {`
`527`		`- return moduleReference.kind === SyntaxKind.ExternalModuleReference && moduleReference.expression.kind === SyntaxKind.StringLiteral`
	`527`	`+ return moduleReference.kind === SyntaxKind.ExternalModuleReference && moduleReference.expression.kind === SyntaxKind.StringLiteral;`
`528`	`528`	`}`
`529`	`529`	`}`
Original file line number	Diff line number	Diff line change
`@@ -481,13 +481,9 @@ namespace ts {`
`481`	`481`	`displayParts: SymbolDisplayPart[];`
`482`	`482`	`}`
`483`	`483`
`484`		`- //!!! internal implementation details leaked!!!`
`485`		`- export interface ReferencedSymbolOf<T extends DocumentSpan> {`
	`484`	`+ export interface ReferencedSymbol {`
`486`	`485`	`definition: ReferencedSymbolDefinitionInfo;`
`487`		`- references: T[];`
`488`		`- }`
`489`		`-`
`490`		`- export interface ReferencedSymbol extends ReferencedSymbolOf<ReferenceEntry> {`
	`486`	`+ references: ReferenceEntry[];`
`491`	`487`	`}`
`492`	`488`
`493`	`489`	`export enum SymbolDisplayPartKind {`