Kmeans .fit() should be changed to .partial_fit() · Issue #2602 · speechbrain/speechbrain · GitHub
Skip to content

Kmeans .fit() should be changed to .partial_fit() #2602

Description

@Beilong-Tang

Describe the bug

Here

You use .fit method on partial of the data. However, I think this should be partial_fit() to update on a small chunk of data. If you call .fit. The kmeans will only apply to that specific data while removing all the previous results.
But I am also not so sure. If this is the case, all experiments built on kmeans would be wrong.

Expected behaviour

Please consider changing the line of code.

To Reproduce

No response

Environment Details

No response

Relevant Log Output

No response

Additional Context

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions