You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
We might want to avoid closing the client when we close the Operator. #65
Currently, the KubernetesClient instance is passed externally to the Operator. I am wondering if its a good idea to close it when we close the Operator, given that its created externally and we can't possibly know who else is using it.
For example, in a test one may close the operator and use the client to perform some cleaning up afterwards, which could possilby lead to issues.
I don't have a strong opinion about it, but my experience from the kubernetes-client tells me that each time we took liberty to close objects passed externally, it didn't end up well and that's why I am bringing this up for discussion.
Activity