We might want to avoid closing the client when we close the Operator. · Issue #65 · snowdrop-zen/java-operator-sdk · GitHub
Skip to content

We might want to avoid closing the client when we close the Operator. #65

Open

Description

@snowdrop-bot

Currently, the KubernetesClient instance is passed externally to the Operator. I am wondering if its a good idea to close it when we close the Operator, given that its created externally and we can't possibly know who else is using it.

For example, in a test one may close the operator and use the client to perform some cleaning up afterwards, which could possilby lead to issues.

I don't have a strong opinion about it, but my experience from the kubernetes-client tells me that each time we took liberty to close objects passed externally, it didn't end up well and that's why I am bringing this up for discussion.


operator-framework#585


$upstream:585$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions