fix(brightdata): return error objects instead of throwing in postProcess

waleedlatif1 · claude · waleedlatif1 · commit b549ee47cd14 · 2026-04-15T14:05:19.000-07:00
The executor wraps postProcess in try-catch and falls back to the
intermediate transformResponse result on error, which has success: true
with empty results. Throwing errors would silently return empty results.

Match Firecrawl's pattern: return { ...result, success: false, error }
instead of throwing. Also add taskId to BrightDataDiscoverResponse type
to eliminate unsafe casts.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/apps/sim/tools/brightdata/discover.ts b/apps/sim/tools/brightdata/discover.ts
@@ -106,71 +106,102 @@ export const brightDataDiscoverTool: ToolConfig<
         totalResults: 0,
         taskId: data.task_id ?? null,
       },
-    } as BrightDataDiscoverResponse
+    }
   },
 
   postProcess: async (result, params) => {
     if (!result.success) return result
 
-    const taskId = (result.output as Record<string, unknown>).taskId as string | null
+    const taskId = result.output.taskId
     if (!taskId) {
-      throw new Error('Discover API did not return a task_id. Cannot poll for results.')
+      return {
+        ...result,
+        success: false,
+        error: 'Discover API did not return a task_id. Cannot poll for results.',
+      }
     }
 
     logger.info(`Bright Data Discover task ${taskId} created, polling for results...`)
 
     let elapsedTime = 0
 
     while (elapsedTime < MAX_POLL_TIME_MS) {
-      const pollResponse = await fetch(
-        `https://api.brightdata.com/discover?task_id=${encodeURIComponent(taskId)}`,
-        {
-          method: 'GET',
-          headers: {
-            Authorization: `Bearer ${params.apiKey}`,
-          },
+      try {
+        const pollResponse = await fetch(
+          `https://api.brightdata.com/discover?task_id=${encodeURIComponent(taskId)}`,
+          {
+            method: 'GET',
+            headers: {
+              Authorization: `Bearer ${params.apiKey}`,
+            },
+          }
+        )
+
+        if (!pollResponse.ok) {
+          return {
+            ...result,
+            success: false,
+            error: `Failed to poll discover results: ${pollResponse.statusText}`,
+          }
         }
-      )
-
-      if (!pollResponse.ok) {
-        throw new Error(`Failed to poll discover results: ${pollResponse.statusText}`)
-      }
 
-      const data = await pollResponse.json()
-      logger.info(`Bright Data Discover task ${taskId} status: ${data.status}`)
+        const data = await pollResponse.json()
+        logger.info(`Bright Data Discover task ${taskId} status: ${data.status}`)
+
+        if (data.status === 'done') {
+          const items = Array.isArray(data.results) ? data.results : []
+
+          const results = items.map((item: Record<string, unknown>) => ({
+            url: (item.link as string) ?? (item.url as string) ?? null,
+            title: (item.title as string) ?? null,
+            description: (item.description as string) ?? (item.snippet as string) ?? null,
+            relevanceScore: (item.relevance_score as number) ?? null,
+            content: (item.content as string) ?? null,
+          }))
+
+          return {
+            success: true,
+            output: {
+              results,
+              query: params.query ?? null,
+              totalResults: results.length,
+            },
+          }
+        }
 
-      if (data.status === 'done') {
-        const items = Array.isArray(data.results) ? data.results : []
+        if (data.status === 'failed' || data.status === 'error') {
+          return {
+            ...result,
+            success: false,
+            error: `Discover task failed: ${data.error ?? 'Unknown error'}`,
+          }
+        }
 
-        const results = items.map((item: Record<string, unknown>) => ({
-          url: (item.link as string) ?? (item.url as string) ?? null,
-          title: (item.title as string) ?? null,
-          description: (item.description as string) ?? (item.snippet as string) ?? null,
-          relevanceScore: (item.relevance_score as number) ?? null,
-          content: (item.content as string) ?? null,
-        }))
+        await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS))
+        elapsedTime += POLL_INTERVAL_MS
+      } catch (error) {
+        logger.error('Error polling for discover task:', {
+          message: error instanceof Error ? error.message : String(error),
+          taskId,
+        })
 
         return {
-          success: true,
-          output: {
-            results,
-            query: params.query ?? null,
-            totalResults: results.length,
-          },
-        } as BrightDataDiscoverResponse
-      }
-
-      if (data.status === 'failed' || data.status === 'error') {
-        throw new Error(`Discover task failed: ${data.error ?? 'Unknown error'}`)
+          ...result,
+          success: false,
+          error: `Error polling for discover task: ${error instanceof Error ? error.message : String(error)}`,
+        }
       }
-
-      await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS))
-      elapsedTime += POLL_INTERVAL_MS
     }
 
-    throw new Error(
-      `Discover task ${taskId} timed out after ${MAX_POLL_TIME_MS / 1000}s. Check status manually.`
+    logger.warn(
+      `Discover task ${taskId} did not complete within the maximum polling time (${MAX_POLL_TIME_MS / 1000}s)`
     )
+
+    return {
+      ...result,
+      success: false,
+      error: `Discover task ${taskId} timed out after ${MAX_POLL_TIME_MS / 1000}s. Check status manually.`,
+    }
   },
 
   outputs: {
diff --git a/apps/sim/tools/brightdata/types.ts b/apps/sim/tools/brightdata/types.ts
@@ -131,6 +131,7 @@ export interface BrightDataDiscoverResponse extends ToolResponse {
     }>
     query: string | null
     totalResults: number
+    taskId?: string | null
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ export interface BrightDataDiscoverResponse extends ToolResponse {`
`131`	`131`	`}>`
`132`	`132`	`query: string \| null`
`133`	`133`	`totalResults: number`
	`134`	`+ taskId?: string \| null`
`134`	`135`	`}`
`135`	`136`	`}`
`136`	`137`