CRITICAL: Insecure pickle deserialization in finetuning pipeline · Issue #377 · shiyu-coder/Kronos · GitHub
Skip to content

CRITICAL: Insecure pickle deserialization in finetuning pipeline #377

Open

Description

@adwaitm1301

In finetune/dataset.py:39 and finetune/qlib_test.py:220,247, pickle.load() is called on data files with no integrity check. Pickle is inherently unsafe - malicious pickle data can execute arbitrary code during deserialization.

Suggested fix: Use safetensors (already a dependency) instead of pickle, or add HMAC signing/verification before loading.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions