Fix LinkedList (trekhleb#42)

m-maksyutin · trekhleb · commit a63bc67cf4ce · 2018-06-02T09:23:55.000+03:00
diff --git a/src/data-structures/linked-list/LinkedList.js b/src/data-structures/linked-list/LinkedList.js
@@ -60,7 +60,7 @@ export default class LinkedList {
     let deletedNode = null;
 
     // If the head must be deleted then make 2nd node to be a head.
-    if (this.compare.equal(this.head.value, value)) {
+    while (this.head && this.compare.equal(this.head.value, value)) {
       deletedNode = this.head;
       this.head = this.head.next;
     }
diff --git a/src/data-structures/linked-list/__test__/LinkedList.test.js b/src/data-structures/linked-list/__test__/LinkedList.test.js
@@ -32,6 +32,7 @@ describe('LinkedList', () => {
 
     expect(linkedList.delete(5)).toBeNull();
 
+    linkedList.append(1);
     linkedList.append(1);
     linkedList.append(2);
     linkedList.append(3);
@@ -45,10 +46,10 @@ describe('LinkedList', () => {
 
     const deletedNode = linkedList.delete(3);
     expect(deletedNode.value).toBe(3);
-    expect(linkedList.toString()).toBe('1,2,4,5');
+    expect(linkedList.toString()).toBe('1,1,2,4,5');
 
     linkedList.delete(3);
-    expect(linkedList.toString()).toBe('1,2,4,5');
+    expect(linkedList.toString()).toBe('1,1,2,4,5');
 
     linkedList.delete(1);
     expect(linkedList.toString()).toBe('2,4,5');

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export default class LinkedList {`
`60`	`60`	`let deletedNode = null;`
`61`	`61`
`62`	`62`	`// If the head must be deleted then make 2nd node to be a head.`
`63`		`- if (this.compare.equal(this.head.value, value)) {`
	`63`	`+ while (this.head && this.compare.equal(this.head.value, value)) {`
`64`	`64`	`deletedNode = this.head;`
`65`	`65`	`this.head = this.head.next;`
`66`	`66`	`}`