FilesExpand file tree

 master

/

expr.c

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

154 lines (128 loc) · 2.7 KB

 master

/

expr.c

Copy path

Top

File metadata and controls

• Code
• Blame

154 lines (128 loc) · 2.7 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

63

64

65

66

67

68

69

70

71

72

73

74

75

76

77

78

79

80

81

82

83

84

85

86

87

88

89

90

91

92

93

94

95

96

97

98

99

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

/*

* EXP08-C. Ensure pointer arithmetic is used correctly

* */

int buf[INTBUFSIZE];

int *buf_ptr = buf;

while (havedata() && buf_ptr < (buf + sizeof(buf))) {

*buf_ptr++ = parseint(getdata());

}

/*

* EXP06-C. Operands to the sizeof operator should not contain side effects

* */

int a = 14;

int b = sizeof(a++);

/*

* EXP02-A. The second operands of the logical AND and OR operators should

not contain side effects

* */

int i;

int max;

if ( (i >= 0 && (i++) <= max) ) {

/* code */

}

/*

* EXP04-A. Do not perform byte-by-byte comparisons between structures

* */

struct my_buf {

size_t size;

char buffer[50];

};

unsigned int buf_compare(struct my_buf *s1, struct my_buf *s2) {

if (!memcmp(s1, s2, sizeof(struct my_struct))) {

return 1;

}

return 0;

}

/*

* EXP30-C. Do not depend on order of evaluation between sequence points

* */

a = i + b[++i];

i = ++i + 1;

a[i++] = i;

func(i++, i);

/*

* EXP31-C. Do not modify constant values

* */

char const **cpp;

char *cp;

char const c = 'A';

cpp = &cp; /* constraint violation */

*cpp = &c; /* valid */

*cp = 'B'; /* valid */

/*

* EXP32-C. Do not access a volatile object through a non-volatile reference

* */

static volatile int **ipp;

static int *ip;

static volatile int i = 0;

printf("i = %d.\n", i);

ipp = &ip; /* constraint violation */

*ipp = &i; /* valid */

if (*ip != 0) { /* valid */

/* ... */

}

/*

* EXP33-C. Do not reference uninitialized variables

* */

void set_flag(int number, int *sign_flag) {

if (number > 0) {

*sign_flag = 1;

}

else if (number < 0) {

*sign_flag = -1;

}

}

void func(int number) {

int sign;

set_flag(number,&sign);

/* ... */

}

int do_auth(void) {

char username[MAX_USER];

char password[MAX_PASS];

puts("Please enter your username: ");

fgets(username, MAX_USER, stdin);

puts("Please enter your password: ");

fgets(password, MAX_PASS, stdin);

if (!strcmp(username, "user") && !strcmp(password, "password")) {

return 0;

}

return -1;

}

void log_error(char *msg) {

char *err;

char *log;

char buffer[24];

sprintf(buffer, "Error: %s", log);

printf("%s\n", buffer);

}

int main(void) {

if (do_auth() == -1) {

log_error("Unable to login");

}

return 0;

}

/*

* EXP35-C. Do not access or modify the result of a function call after a subsequent sequence point

* */

#include <stdio.h>

struct X { char a[6]; };

struct X addressee() {

struct X result = { "world" };

return result;

}

int main(void) {

printf("Hello, %s!\n", addressee().a);

return 0;

}

/*

* EXP36-C. Do not cast between pointers to objects or types with differing alignments

* */

char *loop_ptr;

int *int_ptr;

int *loop_function(void *v_pointer){

return v_pointer;

}

int_ptr = loop_function(loop_ptr);

/* good */

ad->pos = ad->constrained = pos--;