Add comprehensive equality specs · Issue #1418 · sass/sass-spec · GitHub
Skip to content

Add comprehensive equality specs #1418

Open

Description

@nex3

Currently, specs for value equality (like most specs) are spread haphazardly throughout the repo. We should organize them consciously and make sure all edge cases are being tested. Equality specs for each kind of value should live in that value's directory (values/$type/equality.hrx), and they should share assert-equal() and assert-unequal() mixins that verify not only that the values are equal according to == but that all functions that care about equality (index() and various map functions) consider them equal as well.

Activity

  1. stof commented on Oct 31, 2020

    @stof
    Contributor

    @nex3 I think a comprehensive set of specs also need to include another kind of tests: tests about equality between different types of values (where different types are never equal, except for the empty list and the empty map).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions