Adding missing #[inline] by Amanieu · Pull Request #136 · bitflags/bitflags · GitHub
Skip to content

Adding missing #[inline] - #136

Merged
dtolnay merged 1 commit into
bitflags:masterfrom
Amanieu:missing_inline
Nov 12, 2017
Merged

dtolnay merged 1 commit into
bitflags:masterfrom
Amanieu:missing_inline

Conversation

@Amanieu

@Amanieu Amanieu commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

There are a few places that are missing #[inline]. This causes all() to produce inefficient code at runtime when the bitflags are defined in a separate crate.

@dtolnay dtolnay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
dtolnay merged commit 4afd947 into bitflags:master Nov 12, 2017
@dtolnay

dtolnay commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

@Amanieu

Amanieu commented Nov 12, 2017

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants