{{ message }}
Repository navigation
Copy of commit message not updated when force-pushing a PR #21
Description
The copy of the commit message as shown in the submitGit web interface is not updated when e.g. fixing a typo in the commit message and force-pushing the PR. For example, https://submitgit.herokuapp.com/git/git/pull/163 still shows the "--quite" typo at the very beginning of the commit message, whereas clicking on the SHA1 1cb92e18 in the Id column shows that the typo has been fixed to say "--quiet" in the commit.
Activity
rtyley commentedon Jul 23, 2015
The message seen on submitGit is actually a bit of half-finished functionality, which I should probably turn off until it's actually finished. It's not actually your commit message - it's your pull request description, which GitHub initially defaults to your commit message, if there is only one commit. After that, if you force-push a different commit message, the pull request description will not change, tho' obviously the GitHub web interface will let you edit it.
The idea is to optionally make the pull request description into the cover letter for the patch bomb (which would cover #9) - but that was before I ended up launching submitGit a little early, and I haven't got round to that feature yet.
[-]Copy of commit message not updated whrn force-pushing a PR[/-][+]Copy of commit message not updated when force-pushing a PR[/+]sschuberth commentedon Jul 23, 2015
I see. So suppose I would edit the PR's description in the GitHub web interface, would that change also be reflected in submitGit's web interface? If not, is that a planned feature?
rtyley commentedon Jul 23, 2015
Yup, it should do that right now, possibly with a 1-second delay due to caching.
rtyley commentedon Jul 23, 2015
Tho right now, the displayed field doesn't actually do anything, obviously.
sschuberth commentedon Jul 23, 2015
So this issue is more or less invalid, thanks for the clarification. But could we maybe make more clear in submitGit's web interface that the shown text is not directly linked to a commit's message? Maybe add a header above that text field saying something like "Cover letter text" and maybe below that, in smaller letters, "This text is derived from the PR's description" or something like that?