Activity

1. robertroeser

   added

   enhancement

   on Feb 8, 2019
2. robertroeser

   changed the title [-]Add Extenion Frame Support[/-] [+]Add Extension Frame Support[/+] on Feb 8, 2019
3. nebhale commented on Feb 14, 2019

   

   nebhale

   on Feb 14, 2019

   Member

   More actions

   This or #582.
4. linux-china commented on Dec 17, 2019

   

   linux-china

   on Dec 17, 2019

   Last edited by linux-china

   Contributor

   More actions

   @robertroeser if possible to have draft design for frame extension. for example, an interface for Frame handler(ServiceLoader) and payload handler functional interface specification.

   public interface RSocketFrameExtensionHandler {
       int frameType();
   
       int streamIdType();
   
       FrameFlyweight frameFlyWeight();
       
       PayloadDecoder payloadDecoder();
       //functional interface class
       Class<?> handler();
   }
   

   public class RSocketHandlerImpl extends AbstractRSocket implements FrameExtRSocket {
   
       @Override
       public Mono<Payload> savePointAck(Payload payload) {
           return Mono.empty();
       }
   }
   
5. OlegDokuka

   self-assigned this

   on Dec 17, 2019
6. OlegDokuka commented on Dec 17, 2019

   

   OlegDokuka

   on Dec 17, 2019

   Member

   More actions

   @linux-china I will take a look at what could be done
7. yschimke commented on Dec 19, 2019

   

   yschimke

   on Dec 19, 2019

   Last edited by yschimke

   Member

   More actions

   One handy pattern from the Scrooge Thrift compiler, when it doesn't understand elements in a thrift frame, it still allows pass through. So for example a thrift struct gets a new field added, or a new enum value is added which is unknown to the server based on it's deployed thrift IDL. It is still allowed to introspect that element even just pass through when the server is a proxy for example.

   Not sure we want that, or it implies a "must understand" discussion.

   e.g. https://twitter.github.io/scrooge/GeneratedCodeUsage.html
8. OlegDokuka commented on Dec 19, 2019

   

   OlegDokuka

   on Dec 19, 2019

   Member

   More actions

   I guess it would work only in case of proxying on the level of the state machine (frame handler which interprets all the frames)
9. OlegDokuka

   added this to the 1.1 milestone on Apr 5, 2020
10. rstoyanchev

    changed the title [-]Add Extension Frame Support[/-] [+]Support for handling of extension frame[/+] on Apr 17, 2020