`sort-conversations-by-update-time` conflicts with `/pulls/inbox` · Issue #9604 · refined-github/refined-github · GitHub
Skip to content

sort-conversations-by-update-time conflicts with /pulls/inbox #9604

Description

@fregante

Many issues

The global link is hijacked to skip the inbox

Image

GitHub now defaults to the inbox and this can be an option. sort-conversations-by-update-time however will add ?q= to the URL, which causes GitHub to redirect to https://github.com/pulls/search?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen+author%3A%40me+archived%3Afalse+ instead

The sidebar links are already sorted by update time

So the URL should be excluded from sort-conversations-by-update-time

See: https://github.com/pulls/authored

Image

The sidebar links are not recognized correctly

The links are altered from https://github.com/pulls/reviews to https://github.com/pulls/reviews?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen+

Our SearchQuery utility is set up to recognize the pathnames and understand the implied q parameter. Notice how the new q parameter does not include the expected review-requested:@me query

The sidebar links are ignored by GitHub

Even if the links are altered, clicking them will cause GitHub to just load the hardcoded query. This is good considering the bug in the previous section, but if you alt-click the link you'll end up on this non-sensical page:

Image

I think that fixing point 2 or 3 already addresses this issue.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions