`clear-pr-merge-commit-message` should not clear non-squashed merge commit messages · Issue #8399 · refined-github/refined-github · GitHub
Skip to content

clear-pr-merge-commit-message should not clear non-squashed merge commit messages #8399

Description

@cpmsmith

The clear-pr-merge-commit-message now clears the commit message even for merge commits, whereas previously it only cleared when squashing. Based on this exchange, it looks like this is an intentional change, which is why I'm opening this as "under discussion":

A comment and response in which fregante confirms to yutotakano that the behaviour change is intentional

The feature description in the wiki only talks about clearing squashed commits, and under default settings, clearing a merge commit's body will leave only "Merge pull request #​123 from org/repo", removing the PR's title, which is useful information not otherwise included in the commit history.

I would argue the original behaviour was sensible, and it should remain that way. If that's not acceptable, then at least the wiki should be updated.

Metadata

Metadata

Labels

bughelp wantedsmallIssues that new contributors can pick up

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions