Fix PythonException GC (#400)

vmuriart · web-flow · commit edc7621c496d · 2017-02-23T07:55:15.000-07:00
Since PythonException doesn't inherit from PyObject, need to reapply
the same fix as from gh:365.

Seen mostly on PY27/Travis on PyTuple tests.
Enable PyTuple tests for PY27/Travis
diff --git a/src/embed_tests/pytuple.cs b/src/embed_tests/pytuple.cs
@@ -6,29 +6,6 @@ namespace Python.EmbeddingTest
 {
     public class PyTupleTest
     {
-        /// <summary>
-        /// Tests set-up. Being used to skip class on Travis/PY27
-        /// </summary>
-        /// <remarks>
-        /// FIXME: Fails on Travis/PY27: All tests below (unless otherwise stated)
-        /// Fatal Python error: auto-releasing thread-state, but no thread-state for this thread
-        /// Stacktrace:
-        /// at (wrapper managed-to-native) Python.Runtime.Runtime.PyGILState_Release (intptr)
-        /// at Python.Runtime.PythonEngine.ReleaseLock (intptr)
-        /// at Python.Runtime.PythonException.Dispose ()
-        /// at Python.Runtime.PythonException.Finalize ()
-        /// at (wrapper runtime-invoke) object.runtime_invoke_virtual_void__this__ (object,intptr,intptr,intptr)
-        /// </remarks>
-        [SetUp]
-        public void SetUp()
-        {
-            if (Environment.GetEnvironmentVariable("TRAVIS") == "true" &&
-                Environment.GetEnvironmentVariable("TRAVIS_PYTHON_VERSION") == "2.7")
-            {
-                Assert.Ignore("Fails on Travis/PY27: Fatal Python error: auto-releasing thread-state, but no thread-state for this thread");
-            }
-        }
-
         /// <summary>
         /// Test IsTupleType without having to Initialize a tuple.
         /// PyTuple constructor use IsTupleType. This decouples the tests.
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -140,7 +140,7 @@ public void Dispose()
         {
             if (!disposed)
             {
-                if (Runtime.Py_IsInitialized() > 0)
+                if (Runtime.Py_IsInitialized() > 0 && !Runtime.IsFinalizing)
                 {
                     IntPtr gs = PythonEngine.AcquireLock();
                     Runtime.XDecref(_pyType);

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public void Dispose()`
`140`	`140`	`{`
`141`	`141`	`if (!disposed)`
`142`	`142`	`{`
`143`		`- if (Runtime.Py_IsInitialized() > 0)`
	`143`	`+ if (Runtime.Py_IsInitialized() > 0 && !Runtime.IsFinalizing)`
`144`	`144`	`{`
`145`	`145`	`IntPtr gs = PythonEngine.AcquireLock();`
`146`	`146`	`Runtime.XDecref(_pyType);`