Change the builtin hash algorithms' names to lower case names · pythoncapi/cpython@37d5ceb · GitHub
Skip to content

Commit 37d5ceb

Browse files
committed
Change the builtin hash algorithms' names to lower case names
as promised by hashlib's documentation.
1 parent f0e5210 commit 37d5ceb

6 files changed

Lines changed: 11 additions & 8 deletions

File tree

Lib/test/test_hashlib.py

Lines changed: 2 additions & 2 deletions

Misc/NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ Core and Builtins
2828
Library
2929
-------
3030

31+
- Issue #18532: Change the builtin hash algorithms' names to lower case names
32+
as promised by hashlib's documentation.
33+
3134
- Issue #18405: Improve the entropy of crypt.mksalt().
3235

3336
- Issue #12015: The tempfile module now uses a suffix of 8 random characters

Modules/md5module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ MD5_get_block_size(PyObject *self, void *closure)
439439
static PyObject *
440440
MD5_get_name(PyObject *self, void *closure)
441441
{
442-
return PyUnicode_FromStringAndSize("MD5", 3);
442+
return PyUnicode_FromStringAndSize("md5", 3);
443443
}
444444

445445
static PyObject *

Modules/sha1module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ SHA1_get_block_size(PyObject *self, void *closure)
411411
static PyObject *
412412
SHA1_get_name(PyObject *self, void *closure)
413413
{
414-
return PyUnicode_FromStringAndSize("SHA1", 4);
414+
return PyUnicode_FromStringAndSize("sha1", 4);
415415
}
416416

417417
static PyObject *

Modules/sha256module.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,9 +501,9 @@ static PyObject *
501501
SHA256_get_name(PyObject *self, void *closure)
502502
{
503503
if (((SHAobject *)self)->digestsize == 32)
504-
return PyUnicode_FromStringAndSize("SHA256", 6);
504+
return PyUnicode_FromStringAndSize("sha256", 6);
505505
else
506-
return PyUnicode_FromStringAndSize("SHA224", 6);
506+
return PyUnicode_FromStringAndSize("sha224", 6);
507507
}
508508

509509
static PyGetSetDef SHA_getseters[] = {

Modules/sha512module.c

Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)