Improve error message handling in exceptions

Gauvain Pocentek · Gauvain Pocentek · commit 1fb1296c9191 · 2018-11-24T17:37:10.000+01:00
* Depending on the request Gitlab has a 'message' or 'error' attribute in the json data, handle both * Add some consistency by converting messages to unicode or str for exceptions (depending on the python version) Closes #616
diff --git a/gitlab/__init__.py b/gitlab/__init__.py
@@ -490,10 +490,14 @@ def http_request(self, verb, path, query_data={}, post_data=None,
                 time.sleep(wait_time)
                 continue
 
+            error_message = result.content
             try:
-                error_message = result.json()['message']
+                error_json = result.json()
+                for k in ('message', 'error'):
+                    if k in error_json:
+                        error_message = error_json[k]
             except (KeyError, ValueError, TypeError):
-                error_message = result.content
+                pass
 
             if result.status_code == 401:
                 raise GitlabAuthenticationError(
diff --git a/gitlab/exceptions.py b/gitlab/exceptions.py
@@ -28,7 +28,12 @@ def __init__(self, error_message="", response_code=None,
         # Full http response
         self.response_body = response_body
         # Parsed error message from gitlab
-        self.error_message = error_message
+        try:
+            # if we receive str/bytes we try to convert to unicode/str to have
+            # consistent message types (see #616)
+            self.error_message = error_message.decode()
+        except Exception:
+            self.error_message = error_message
 
     def __str__(self):
         if self.response_code is not None:
