{{ message }}
gh-108253: Fix bug in func version cache - #108296
Merged
Merged
Conversation
When a function object changed its version, a stale pointer might remain in the cache.
Member
Member
Author
Interesting, since it also definitely fixed a case of free-after-use. I will try to understand the report. |
Member
Author
|
Ah, I was over-zealous. That is the one place where |
Member
|
Thanks! |
Member
Author
|
This is a great service! Surprised though that address-sanitizer didn't catch this. |
Member
|
ASAN doesn't catch unitialized memory, only MSAN does. (And MSAN is kind of a pain in the neck to setup.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a function object changed its version, a stale pointer might remain in the cache.
Now,
test_opcachejust fails when run with-Xuopsinstead of accessing freed memory. This fixes gh-108253.