gh-133379: Correct usage of `arguments` in error messages by StanFromIreland · Pull Request #133382 · python/cpython · GitHub
Skip to content

gh-133379: Correct usage of arguments in error messages#133382

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:correct-errors
May 10, 2025
Merged

gh-133379: Correct usage of arguments in error messages#133382
serhiy-storchaka merged 5 commits into
python:mainfrom
StanFromIreland:correct-errors

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 4, 2025

Copy link
Copy Markdown
Member

Not quite sure what the title should be for this.

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title looks great to me

@picnixz

picnixz commented May 4, 2025

Copy link
Copy Markdown
Member

@serhiy-storchaka

Copy link
Copy Markdown
Member

What is the difference between #133382 and #133463?

@StanFromIreland

Copy link
Copy Markdown
Member Author

Other error messages are corrected.

@picnixz

picnixz commented May 9, 2025

Copy link
Copy Markdown
Member

Following #133463 (comment), I suggest we fix everything here.

@StanFromIreland

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit dbca27c into python:main May 10, 2025
@StanFromIreland StanFromIreland deleted the correct-errors branch May 10, 2025 12:02
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants