[3.12] gh-151981: Make tarfile._Stream.seek break at EOF (GH-151982) … · python/cpython@f5e2776 · GitHub
Skip to content

Commit f5e2776

Browse files
miss-islingtonencukouStanFromIreland
authored
[3.12] gh-151981: Make tarfile._Stream.seek break at EOF (GH-151982) (#151994)
gh-151981: Make tarfile._Stream.seek break at EOF (GH-151982) (cherry picked from commit f50bf13) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Stan Ulbrych <stan@python.org>
1 parent 03ab7b4 commit f5e2776

3 files changed

Lines changed: 21 additions & 1 deletion

File tree

‎Lib/tarfile.py‎

Lines changed: 3 additions & 1 deletion

‎Lib/test/test_tarfile.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4558,6 +4558,22 @@ def valueerror_filter(tarinfo, path):
45584558
with self.check_context(arc.open(errorlevel='boo!'), filtererror_filter):
45594559
self.expect_exception(TypeError) # errorlevel is not int
45604560

4561+
@support.subTests('format', [tarfile.GNU_FORMAT, tarfile.PAX_FORMAT])
4562+
def test_getmembers_big_size(self, format):
4563+
# gh-151981: A loop in seek() for streaming files tried to read the
4564+
# declared number of blocks even at EOF
4565+
tinfo = tarfile.TarInfo("huge-file")
4566+
tinfo.size = 1 << 64
4567+
bio = io.BytesIO()
4568+
# Write header without data
4569+
bio.write(tinfo.tobuf(format))
4570+
4571+
# Reset & try to get contents
4572+
bio.seek(0)
4573+
with tarfile.open(fileobj=bio, mode="r|") as tar:
4574+
with self.assertRaises(tarfile.ReadError):
4575+
tar.getmembers()
4576+
45614577

45624578
class OverwriteTests(archiver_tests.OverwriteTests, unittest.TestCase):
45634579
testdir = os.path.join(TEMPDIR, "testoverwrite")

‎Misc/NEWS.d/next/Security/2026-06-23-13-28-16.gh-issue-151981.xBHEcU.rst‎

Lines changed: 2 additions & 0 deletions

0 commit comments

Comments
 (0)