bpo-36035: fix Path.rglob for broken links (GH-11988) · python/cpython@d5c120f · GitHub
Skip to content

Commit d5c120f

Browse files
jstuckepitrou
authored andcommitted
bpo-36035: fix Path.rglob for broken links (GH-11988)
Links creating an infinite symlink loop would raise an exception.
1 parent ccb7ca7 commit d5c120f

3 files changed

Lines changed: 17 additions & 5 deletions

File tree

Lib/pathlib.py

Lines changed: 10 additions & 3 deletions

Lib/test/test_pathlib.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1221,7 +1221,8 @@ class _BasePathTest(object):
12211221
# |-- dirE # No permissions
12221222
# |-- fileA
12231223
# |-- linkA -> fileA
1224-
# `-- linkB -> dirB
1224+
# |-- linkB -> dirB
1225+
# `-- brokenLinkLoop -> brokenLinkLoop
12251226
#
12261227

12271228
def setUp(self):
@@ -1252,6 +1253,8 @@ def cleanup():
12521253
self.dirlink(os.path.join('..', 'dirB'), join('dirA', 'linkC'))
12531254
# This one goes upwards, creating a loop.
12541255
self.dirlink(os.path.join('..', 'dirB'), join('dirB', 'linkD'))
1256+
# Broken symlink (pointing to itself).
1257+
os.symlink('brokenLinkLoop', join('brokenLinkLoop'))
12551258

12561259
if os.name == 'nt':
12571260
# Workaround for http://bugs.python.org/issue13772.
@@ -1384,7 +1387,7 @@ def test_iterdir(self):
13841387
paths = set(it)
13851388
expected = ['dirA', 'dirB', 'dirC', 'dirE', 'fileA']
13861389
if support.can_symlink():
1387-
expected += ['linkA', 'linkB', 'brokenLink']
1390+
expected += ['linkA', 'linkB', 'brokenLink', 'brokenLinkLoop']
13881391
self.assertEqual(paths, { P(BASE, q) for q in expected })
13891392

13901393
@support.skip_unless_symlink
@@ -1465,6 +1468,7 @@ def test_rglob_symlink_loop(self):
14651468
'fileA',
14661469
'linkA',
14671470
'linkB',
1471+
'brokenLinkLoop',
14681472
}
14691473
self.assertEqual(given, {p / x for x in expect})
14701474

Lines changed: 1 addition & 0 deletions

0 commit comments

Comments
 (0)