gh-91447: Fix findtext to only give an empty string on None (GH-91486) · python/cpython@a95e60d · GitHub
Skip to content

Commit a95e60d

Browse files
gh-91447: Fix findtext to only give an empty string on None (GH-91486)
The API documentation for [findtext](https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.findtext) states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to `None`. Resolves #91447. Automerge-Triggered-By: GH:gvanrossum
1 parent 858c9a5 commit a95e60d

3 files changed

Lines changed: 19 additions & 1 deletion

File tree

Lib/test/test_xml_etree.py

Lines changed: 14 additions & 0 deletions

Lib/xml/etree/ElementPath.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,6 +416,8 @@ def findall(elem, path, namespaces=None):
416416
def findtext(elem, path, default=None, namespaces=None):
417417
try:
418418
elem = next(iterfind(elem, path, namespaces))
419-
return elem.text or ""
419+
if elem.text is None:
420+
return ""
421+
return elem.text
420422
except StopIteration:
421423
return default
Lines changed: 2 additions & 0 deletions

0 commit comments

Comments
 (0)