gh-112125: Fix None.__ne__(None) returning NotImplemented instead of … · python/cpython@9c3458e · GitHub
Skip to content

Commit 9c3458e

Browse files
gh-112125: Fix None.__ne__(None) returning NotImplemented instead of False (#112504)
1 parent b449415 commit 9c3458e

5 files changed

Lines changed: 15 additions & 1 deletion

File tree

Include/internal/pycore_typeobject.h

Lines changed: 2 additions & 0 deletions

Lib/test/test_builtin.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,11 @@ def __dir__(self):
627627
# test that object has a __dir__()
628628
self.assertEqual(sorted([].__dir__()), dir([]))
629629

630+
def test___ne__(self):
631+
self.assertFalse(None.__ne__(None))
632+
self.assertTrue(None.__ne__(0))
633+
self.assertTrue(None.__ne__("abc"))
634+
630635
def test_divmod(self):
631636
self.assertEqual(divmod(12, 7), (1, 5))
632637
self.assertEqual(divmod(-12, 7), (-2, 2))
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix None.__ne__(None) returning NotImplemented instead of False

Objects/object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2026,7 +2026,7 @@ PyTypeObject _PyNone_Type = {
20262026
0, /*tp_doc */
20272027
0, /*tp_traverse */
20282028
0, /*tp_clear */
2029-
0, /*tp_richcompare */
2029+
_Py_BaseObject_RichCompare, /*tp_richcompare */
20302030
0, /*tp_weaklistoffset */
20312031
0, /*tp_iter */
20322032
0, /*tp_iternext */

Objects/typeobject.c

Lines changed: 6 additions & 0 deletions

0 commit comments

Comments
 (0)