bpo-35733: Make isinstance(ast.Constant(boolean), ast.Num) be false. … · python/cpython@7417622 · GitHub
Skip to content

Commit 7417622

Browse files
asottileserhiy-storchaka
authored andcommitted
bpo-35733: Make isinstance(ast.Constant(boolean), ast.Num) be false. (GH-11547)
1 parent 39ed289 commit 7417622

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

Lib/ast.py

Lines changed: 7 additions & 1 deletion

Lib/test/test_ast.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,12 +411,16 @@ def test_isinstance(self):
411411
self.assertFalse(isinstance(ast.Str('42'), ast.Bytes))
412412
self.assertFalse(isinstance(ast.Num(42), ast.NameConstant))
413413
self.assertFalse(isinstance(ast.Num(42), ast.Ellipsis))
414+
self.assertFalse(isinstance(ast.NameConstant(True), ast.Num))
415+
self.assertFalse(isinstance(ast.NameConstant(False), ast.Num))
414416

415417
self.assertFalse(isinstance(ast.Constant('42'), ast.Num))
416418
self.assertFalse(isinstance(ast.Constant(42), ast.Str))
417419
self.assertFalse(isinstance(ast.Constant('42'), ast.Bytes))
418420
self.assertFalse(isinstance(ast.Constant(42), ast.NameConstant))
419421
self.assertFalse(isinstance(ast.Constant(42), ast.Ellipsis))
422+
self.assertFalse(isinstance(ast.Constant(True), ast.Num))
423+
self.assertFalse(isinstance(ast.Constant(False), ast.Num))
420424

421425
self.assertFalse(isinstance(ast.Constant(), ast.Num))
422426
self.assertFalse(isinstance(ast.Constant(), ast.Str))
Lines changed: 2 additions & 0 deletions

0 commit comments

Comments
 (0)