Update authentication helper so it works correctly with Django versions

Kami · Kami · commit 0aef0fdf2aa2 · 2020-02-11T20:20:32.000+01:00
where "request.user.is_authentication" variable is a property and not a
method (aka newer Django versions.)
diff --git a/codespeed/auth.py b/codespeed/auth.py
@@ -1,4 +1,5 @@
 import logging
+import types
 from functools import wraps
 from django.contrib.auth import authenticate, login
 from django.http import HttpResponse, HttpResponseForbidden
@@ -9,6 +10,20 @@
 logger = logging.getLogger(__name__)
 
 
+def is_authenticated(request):
+    # NOTE: We do type check so we also support newer versions of Djando when
+    # is_authenticated and some other methods have been properties
+    if isinstance(request.user.is_authenticated, (types.FunctionType,
+                                                  types.MethodType)):
+        return request.user.is_authenticated()
+    elif isinstance(request.user.is_authenticated, bool):
+        return request.user.is_authenticated
+    else:
+        logger.info('Got unexpected type for request.user.is_authenticated '
+                    'variable')
+        return False
+
+
 def basic_auth_required(realm='default'):
     def _helper(func):
         @wraps(func)
@@ -18,7 +33,7 @@ def _decorator(request, *args, **kwargs):
             if settings.ALLOW_ANONYMOUS_POST:
                 logger.debug('allowing anonymous post')
                 allowed = True
-            elif hasattr(request, 'user') and request.user.is_authenticated():
+            elif hasattr(request, 'user') and is_authenticated(request=request):
                 allowed = True
             elif 'HTTP_AUTHORIZATION' in request.META:
                 logger.debug('checking for http authorization header')
