Hay and Davies Modification for infinite_sheds #1551
-
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 6 replies
-
|
Hi John, I think this would be a super improvement. Would it be possible to have Hay-Davies be an option? IE: add a |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your reply, Mark. I was thinking of adding something along the lines of a poa_method argument as you suggest--it seems like the most flexible approach. I may ask for your help there, assuming this moves forward as an issue. The code I used in the modification to _poa_sky_diffuse_pv function is directly from the pvlib.irradiance.haydavies function. However, I did not apply the vf integration terms (vf_shade_sky_integ and vf_noshade_sky_integ) to the circumsolar term in haydavies. This is related to Cliff's comment below, and I'll reply there as well. |
Beta Was this translation helpful? Give feedback.
-
|
My concern is that the calculations in The Hay-Davies model differs from the simple, isotropic sky model, only by distinguishing circumsolar irradiance from the rest of sky diffuse irradiance. The output of the pvlib One could create a work-around by creating a variant of Hay-Davies that returns the circumsolar and rest-of-sky irradiance separately, adding the circumsolar to direct irradiance, and using rest-of-sky as DHI. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, Cliff. This is helpful. So the workaround I was thinking of is shown in the screenshot above, where I apply the vf integration terms (vf_shade_sky_integ and vf_noshade_sky_integ) to the rest-of-sky irradiance term from haydavies but not the circumsolar term. Is that technically correct, or no? Would I need similar workarounds for other functions besides _poa_sky_diffuse_pv in infinite_sheds? |
Beta Was this translation helpful? Give feedback.
-
|
I don't think that's correct. The first term (DHI x AI x Rb) is the circumsolar irradiance received directly on the tilted plane, shaded and unshaded; I think it should be multiplied by f_x so that circumsolar falls only on the unshaded portion of the tilted plane. The other term (DHI x (1 - AI) x (weighted sum of view factors) is the rest-of-sky diffuse that is received on both shaded and unshaded portions. This may be half of the needed modification. The other portion would be in the calculation of ground-reflected irradiance received on the tilted plane, which assumes that the incoming diffuse irradiance (circumsolar and rest-of-sky) to the ground is isotropic. That's implemented in a sequence of private functions starting here. I think it would easier (and more explainable) to use |
Beta Was this translation helpful? Give feedback.
-
|
It's a good question to ask: why is circumsolar not already in direct? My opinion, because measured DNI excludes circumsolar, because (in turn) the instruments that measure DNI are designed that way. |
Beta Was this translation helpful? Give feedback.
-
|
Much appreciated, Cliff. If I understand correctly, you're suggesting to just use get_irradiance_poa as is but with the dhi = rest-of-sky diffuse and dni = DNI + circumsolar, where rest-of-sky diffuse and circumsolar components are determined from the Hay and Davies sky diffuse model. Perhaps that's still worth building into the functionality of infinite_sheds? E.g., have an argument for poa_method as Mark suggested, and then if the method is 'haydavies', apply/transform dhi = rest-of-sky diffuse and dni = DNI + circumsolar? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
My concern is that the calculations in
infinite_shedsthat use view factors, e.g., reflections from the ground to the rear surface, implicitly assume that the incoming irradiance is isotropic. There's no weighting or other accommodation in the view factor to account for non-isotropic sources.The Hay-Davies model differs from the simple, isotropic sky model, only by distinguishing circumsolar irradiance from the rest of sky diffuse irradiance. The output of the pvlib
hay-daviesfunction is the sum of both quantities. It may be reasonable to combine Hay-Davies sky diffuse with the isotropic view factors, but it's important to acknowledge the inconsistency.One could create a work-around by…