Comparing master...trh/make-cutoff-ready · purescript/purescript · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: purescript/purescript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: purescript/purescript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: trh/make-cutoff-ready
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 35 files changed
  • 3 contributors

Commits on Jun 9, 2025

  1. Make cut-off, the main piece

    wclr committed Jun 9, 2025
    Configuration menu
    Copy the full SHA
    118a12f View commit details
    Browse the repository at this point in the history
  2. Fix linting error.

    wclr committed Jun 9, 2025
    Configuration menu
    Copy the full SHA
    69f94f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d4a4ad6 View commit details
    Browse the repository at this point in the history
  4. Add comments to BuildPlan

    wclr committed Jun 9, 2025
    Configuration menu
    Copy the full SHA
    28f3bf0 View commit details
    Browse the repository at this point in the history
  5. Added requested changes, don't recompile downstream after the error, …

    …tests updated and commented.
    wclr committed Jun 9, 2025
    Configuration menu
    Copy the full SHA
    1d25867 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bde9483 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    31aba1a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a49b446 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2026

  1. Configuration menu
    Copy the full SHA
    c5c0742 View commit details
    Browse the repository at this point in the history
  2. Remove modules that fail to build

    Otherwise compiling again without changes returns status 0
    and no errors.
    MonoidMusician committed Jan 14, 2026
    Configuration menu
    Copy the full SHA
    bd8d162 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7987364 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2026

  1. Configuration menu
    Copy the full SHA
    1f3a21e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a076b30 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2026

  1. Configuration menu
    Copy the full SHA
    c420b5c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2026

  1. Configuration menu
    Copy the full SHA
    1893622 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2026

  1. misc build cutoff fixes and add --no-cutoff flag

    fixes issues found in the incremental builds, via comparing incremental
    vs. clean builds on example projects like prelude
    
    Each of these caused a stale but successful build:
    
    - Re-exports via unqualified imports (`module B (module A) where
      import A`, the common prelude pattern) were not matched against
      downstream usage, so changes or removals flowing through such
      re-exports failed to rebuild consumers.
    - Newly added re-exports were absent from the externs diff, so a name
      newly brought into scope could not trigger a rebuild of a module it
      made ambiguous.
    - do/ado notation and unary minus desugar into references to bind,
      discard, map, apply, pure and negate that are not present in the
      parsed module, so changes to those names went undetected.
    
    Rename handling:
    
    - Re-stamp codegen outputs after patching externs in place, otherwise
      every patched module was needlessly recompiled on the next build.
    - Patch instance chain ids as well as source spans, otherwise a moved
      file's old path lingered in externs and incremental output diverged
      from a clean build.
    - Rebuild a moved module when corefn, docs or source-map targets are
      requested, since those embed the module's own source path.
    
    This also adds a --no-cutoff flag to `purs compile` to rebuild everything
    downstream of a change, matching older compilers, to help diagnose an
    unexpected build result.
    
    It also restores the cut-off test cases dropped in an earlier refactor,
    ports the regression tests from the purserl fork, and adds some more
    adversarial and rename and --no-cutoff tests in TestMake.hs
    thomashoneyman committed Jul 8, 2026
    Configuration menu
    Copy the full SHA
    aa9e76d View commit details
    Browse the repository at this point in the history
Loading