Graphics/Tools at master · prefrontalcortex/Graphics · GitHub
Skip to content

Tools

Directory actions

More options

Directory actions

More options

Latest commit

 

History

History
 
 

Tools

readme.md

Tools

Questions: #devs-graphics-automation

Git-hooks

Git hooks are a way to ensure that certain rules are being followed within a repo. They provide a way to run local checks before pushing code to the remote, allowing developers to catch issues sooner and iterate faster.

For example, compliance with Unity's code convention is mandatory in order to merge a PR into master. While there are server side scripts that will check the code, you can save some time by installing these hooks and ensure to push formatted code to the remote.

Installation

Follow these steps to install the git hooks before working on the Graphics repository:

  1. Requirement A: Install Python >= 3.5 and make sure it is accessible in your PATH.
  2. Requirement B: Install pip3.
  3. Requirement C: Make sure unity-meta is installed and its requirements are fulfilled. It will be used by the format code hook to ensure your code complies with the convention. Sidenote: it is the same tool used to format C++/trunk code.
  4. Requirement D: Make sure you have access to the cds.github.com repositories. Usually this means following these steps to create and upload an ssh key to cds.github.com.
  5. From the root of the repository, run cd Tools and python3 ./hooks_setup.py.

Note: If you already installed the git hooks (before November 2020), you need to follow the steps above to re-install them. This is required in order to move towards a more scalable and flexible system. Sidenote: NodeJS and the node_modules folder are no longer required.

Available hooks

A description of the hooks we currently have is available in the hooks' library repository.

For this repository we have enabled:

  • format-code
  • check-shader-includes
  • file-extension-to-lowercase
  • check-branch-name

FAQ and Troubleshooting steps

How to make sure the hooks are correctly installed?

This is the output of a successful installation:

[INFO]   Running: git lfs install --force
[INFO]   Running: git rev-parse --show-toplevel
[INFO]   Running: pip3 install pre-commit
[INFO]   Running: pre-commit install --allow-missing-config
[INFO]   Running: pre-commit install --hook-type pre-push --allow-missing-config
[INFO]   Running: git rev-parse --show-toplevel
[INFO]   Running: where perl
[INFO]   Running: git ls-remote git@github.cds.internal.unity3d.com:theo-penavaire/gfx-automation-tools.git HEAD
Successfully installed the git hooks. Thank you!

Additionally, you can run the following commands to make sure the hooks are triggered on git operations:

echo "test" > test.txt
git add test.txt
git commit -m "test"
// Some kind of output about the hooks being run
// Do a reset to undo our test: git reset --soft HEAD~1 (This "undoes" the last commit and keep the committed files in your staging area so delete test.txt after)

Permission denied (SSH) when installing the git hooks

Please, follow these steps: https://docs.github.com/en/enterprise-server@2.21/github/authenticating-to-github/connecting-to-github-with-ssh. Do not forget the ssh agent step.

If that still doesn’t work, try running

ssh -vT git@github.cds.internal.unity3d.com

Look for a line starting by “Offering public key...”. It will tell you which ssh key is being used by shh. This key must be the one you uploaded to github.cds.

Last resort: Troubleshooting SSH section in Github docs.

Python or pre-commit not found, even if python is installed, "/usr/bin/env: ‘python’: Permission denied"

Make sure Python (>=3.5) is in your PATH. Commands that can help:

When running the Python installer on Windows, make sure to check "Add Python to Path"!

If python can't find the pre-commit package, make sure the Scripts folder outputted in the error is in the PATH too (use where pre-commit or which pre-commit to check which folder it is in).

A clean reinstall of Python solves most issues. Make sure to rerun the hooks_setup.py script after you reinstall Python.

Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases.

Run python instead of python3.

bash: /path/to/AppData/Local/Microsoft/WindowsApps/python: Permission denied

Follow the suggestions of this StackOverflow answer.

Can't locate Win32/Process.pm in @INC...

On Windows, Active perl is not supported by the formatting tool. Use Strawberry perl.