updated import style; put the version info on top of error message; f… · precommit/pre-commit@de63b6a · GitHub
Skip to content

Commit de63b6a

Browse files
committed
updated import style; put the version info on top of error message; fixed tests
1 parent 247d45a commit de63b6a

3 files changed

Lines changed: 26 additions & 23 deletions

File tree

pre_commit/error_handler.py

Lines changed: 6 additions & 4 deletions

tests/error_handler_test.py

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -104,29 +104,30 @@ def test_log_and_exit(cap_out, mock_store_dir):
104104

105105
printed = cap_out.get()
106106
log_file = os.path.join(mock_store_dir, 'pre-commit.log')
107-
printed_lines = printed.split('\n')
108-
assert len(printed_lines) == 6, printed_lines
109-
assert printed_lines[0] == 'msg: FatalError: hai'
107+
printed_lines = printed.splitlines()
108+
print(printed_lines)
109+
assert len(printed_lines) == 7
110+
assert printed_lines[0] == '### version information'
110111
assert re.match(r'^pre-commit.version=\d+\.\d+\.\d+$', printed_lines[1])
111112
assert printed_lines[2].startswith('sys.version=')
112113
assert printed_lines[3].startswith('sys.executable=')
113-
assert printed_lines[4] == 'Check the log at {}'.format(log_file)
114-
assert printed_lines[5] == '' # checks for \n at the end of last line
114+
assert printed_lines[4] == '### error information'
115+
assert printed_lines[5] == 'msg: FatalError: hai'
116+
assert printed_lines[6] == 'Check the log at {}'.format(log_file)
115117

116118
assert os.path.exists(log_file)
117119
with io.open(log_file) as f:
118-
logged_lines = f.read().split('\n')
119-
assert len(logged_lines) == 6, logged_lines
120-
assert logged_lines[0] == 'msg: FatalError: hai'
120+
logged_lines = f.read().splitlines()
121+
assert len(logged_lines) == 7
122+
assert printed_lines[0] == '### version information'
121123
assert re.match(
122124
r'^pre-commit.version=\d+\.\d+\.\d+$',
123125
printed_lines[1],
124126
)
125127
assert logged_lines[2].startswith('sys.version=')
126128
assert logged_lines[3].startswith('sys.executable=')
127-
assert logged_lines[4] == "I'm a stacktrace"
128-
# checks for \n at the end of stack trace
129-
assert printed_lines[5] == ''
129+
assert logged_lines[5] == 'msg: FatalError: hai'
130+
assert logged_lines[6] == "I'm a stacktrace"
130131

131132

132133
def test_error_handler_non_ascii_exception(mock_store_dir):
@@ -148,7 +149,8 @@ def test_error_handler_no_tty(tempdir_factory):
148149
pre_commit_home=pre_commit_home,
149150
)
150151
log_file = os.path.join(pre_commit_home, 'pre-commit.log')
151-
output_lines = output[1].replace('\r', '').split('\n')
152-
assert output_lines[0] == 'An unexpected error has occurred: ValueError: ☃'
153-
assert output_lines[-2] == 'Check the log at {}'.format(log_file)
154-
assert output_lines[-1] == '' # checks for \n at the end of stack trace
152+
output_lines = output[1].replace('\r', '').splitlines()
153+
assert (
154+
output_lines[-2] == 'An unexpected error has occurred: ValueError: ☃'
155+
)
156+
assert output_lines[-1] == 'Check the log at {}'.format(log_file)

tests/main_test.py

Lines changed: 3 additions & 4 deletions

0 commit comments

Comments
 (0)