Not super clear when a return value is necessary, and when modifying a value by reference works. · Issue #292 · posthtml/posthtml · GitHub
Skip to content

Not super clear when a return value is necessary, and when modifying a value by reference works. #292

Open

Description

@Scrum

Changes made. The latest commit adds a lot of complexity, but nice type inference. I also realized when doing some of this that it's not super clear when a return value is necessary, and when modifying a value by reference works. For example, the callback to tree.match must return a Node (or RawNode), but the plugin itself doesn't have to return the tree. It's unclear what would happen if a plugin both modified the tree by reference and returned a new one.

2019-08-28-140552_790x1028_scrot

Originally posted by @caseyWebb in #291 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions